mariofusco commented on PR #5674: URL: https://github.com/apache/incubator-kie-drools/pull/5674#issuecomment-1928931840
> I suggest this change be pulled anyway as it is very clear that this could throw an NPE anytime. Sorry but no, this is not how we work generally. All the null checks that we have are there for a valid reason, and without a reproducer I cannot know if in this case it is valid or not. In many cases adding a null check is not a fix, but only a workaround for a bug that is happening somewhere else along the rules evaluation chain. When this happens simply adding the null checks is not acceptable because it doesn't fix the root cause of the problem, but conversely just hides the error, propagating it even further and making it even harder to be investigated. When I add a null check I'm saying "I know why and in which circumstance this value could be null and it is expected and acceptable to be it" and not "let's add one more null check just in case". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
