ljmotta commented on code in PR #2146:
URL:
https://github.com/apache/incubator-kie-tools/pull/2146#discussion_r1481794475
##########
packages/dmn-editor/src/diagram/nodes/DefaultSizes.ts:
##########
@@ -24,36 +24,52 @@ import { NodeType } from "../connections/graphStructure";
import { NODE_TYPES } from "./NodeTypes";
import { CONTAINER_NODES_DESIRABLE_PADDING } from "../maths/DmnMaths";
-export const MIN_NODE_SIZES: Record<NodeType, (snapGrid: SnapGrid) =>
DC__Dimension> = {
- [NODE_TYPES.inputData]: (snapGrid) => {
+export const MIN_NODE_SIZES: Record<
+ NodeType,
+ ({
+ snapGrid,
+ isAlternativeInputDataShape,
+ }: {
+ snapGrid: SnapGrid;
+ isAlternativeInputDataShape?: boolean;
Review Comment:
The MIN_NODE_SIZES is used by all nodes, which doesn't have an alternative
shape. I made it optional to not polute the codebase with a specific node
property on all function calls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
