tiagobento commented on code in PR #2146:
URL:
https://github.com/apache/incubator-kie-tools/pull/2146#discussion_r1481913558
##########
packages/dmn-editor/src/diagram/nodes/DefaultSizes.ts:
##########
@@ -24,36 +24,52 @@ import { NodeType } from "../connections/graphStructure";
import { NODE_TYPES } from "./NodeTypes";
import { CONTAINER_NODES_DESIRABLE_PADDING } from "../maths/DmnMaths";
-export const MIN_NODE_SIZES: Record<NodeType, (snapGrid: SnapGrid) =>
DC__Dimension> = {
- [NODE_TYPES.inputData]: (snapGrid) => {
+export const MIN_NODE_SIZES: Record<
+ NodeType,
+ ({
+ snapGrid,
+ isAlternativeInputDataShape,
+ }: {
+ snapGrid: SnapGrid;
+ isAlternativeInputDataShape?: boolean;
Review Comment:
@ljmotta You could work some TypeScript "magic" to make calls with a
constant argument resolve to a type that doesn't need this parameter, however,
from the entire domain's perspective, this parameter is mandatory, since
`InputData` nodes require it. Making it optional for all cases, also makes it
optional for `InputData`, which is incorrect. We always need to know whether or
the `InputData` node is in its alternative or classic form.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
