jomarko commented on code in PR #2158:
URL:
https://github.com/apache/incubator-kie-tools/pull/2158#discussion_r1489183192
##########
packages/dmn-editor/dev-webapp/src/DevWebApp.tsx:
##########
@@ -45,7 +43,13 @@ const EMPTY_DMN_15 = () => `<?xml version="1.0"
encoding="UTF-8"?>
name="DMN${generateUuid()}">
</definitions>`;
-export function DevWebApp() {
+interface DevWebAppProps {
+ initialModel: string;
+}
+
+export function DevWebApp(props: DevWebAppProps) {
+ const initialDmnMarshaller = useMemo(() => getMarshaller(props.initialModel,
{ upgradeTo: "latest" }), []);
Review Comment:
This is the only component I use in storybook for now. I refactored it to
take the model string as a function component `prop`.
My general question is, if we should keep the current structure, I mean if
we should keep `dmn-editor/dev-webapp` folder, related `package.json` scripts,
like `start` and related `webpack.config.js` or we should move the code from
`dev-webapp` elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
