jomarko commented on code in PR #2158:
URL:
https://github.com/apache/incubator-kie-tools/pull/2158#discussion_r1489192090
##########
packages/dmn-editor/package.json:
##########
@@ -20,11 +20,17 @@
"build:dev": "rimraf dist && pnpm copy:css && tsc -p tsconfig.json",
"build:dev-webapp": "rimraf ./dist-dev && webpack -c
./dev-webapp/webpack.config.js --env prod",
"build:prod": "rimraf dist && pnpm copy:css && pnpm lint && tsc -p
tsconfig.json && pnpm test && pnpm test:it",
+ "build:storybook": "storybook build -o dist-storybook",
"copy:css": "copyfiles -u 1 \"src/**/*.{sass,scss,css}\" dist/",
"lint": "run-script-if --bool \"$(build-env linters.run)\" --then
\"kie-tools--eslint ./src\"",
"start": "webpack serve -c ./dev-webapp/webpack.config.js --host 0.0.0.0
--env dev",
+ "start:new": "run-script-os",
+ "start:new:linux:darwin": "cross-env STORYBOOK_PORT=$(build-env
dmnEditor.storybook.port) pnpm storybook-base --storybookArgs=\"dev
--no-open\"",
+ "start:new:win32": "pnpm powershell \"cross-env STORYBOOK_PORT=$(build-env
dmnEditor.storybook.port) pnpm storybook-base --storybookArgs='dev --no-open'",
"test": "run-script-if --ignore-errors \"$(build-env
tests.ignoreFailures)\" --bool \"$(build-env tests.run)\" --then \"jest
--silent --verbose --passWithNoTests\"",
- "test:it": "echo 'No IT tests to run at this moment.'"
+ "test:e2e": "run-script-if --ignore-errors \"$(build-env
endToEndTests.ignoreFailures)\" --bool \"$(build-env endToEndTests.run)\"
--then \"pnpm rimraf ./dist-e2e\" \"pnpm test:e2e:run\"",
+ "test:e2e:open": "pnpm exec playwright show-report dist-e2e-tests/reports",
+ "test:e2e:run": "pnpm exec playwright test --project=chromium"
Review Comment:
tried to align with `boxed-expression-component`. currently we have `start`
and `start:new`, it is related to my [question
](https://github.com/apache/incubator-kie-tools/pull/2158/files#r1489183192)
how intensive should be the cleanup of existing `dev-webapp`. if we agree
there should eb cleanup, I will remove old `start` and `build:dev-webapp` and
rename `start:new` as `start`, so we have in the end of the day single `start`
script command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
