tiagobento commented on code in PR #2202:
URL:
https://github.com/apache/incubator-kie-tools/pull/2202#discussion_r1534501489
##########
packages/stunner-editors-dmn-loader/src/beeToGwt.ts:
##########
Review Comment:
I think this would be `dmnToGwt`.
##########
packages/stunner-editors/kie-wb-common-dmn/kie-wb-common-dmn-client/src/main/java/org/kie/workbench/common/dmn/client/editors/expressions/jsinterop/util/ExpressionPropsFiller.java:
##########
@@ -105,7 +105,7 @@ public static ExpressionProps
buildAndFillJsInteropProp(final Expression wrapped
outputConvertForDecisionTableProps(decisionTableExpression, expressionName,
dataType),
rulesConvertForDecisionTableProps(decisionTableExpression));
}
- return new ExpressionProps(expressionId, expressionName, dataType,
UNDEFINED.getText());
+ return null;
Review Comment:
Doesn't this have bad implications? I mean, `gwtToDmn` and `dmnToGwt` should
be able to handle it, no?
##########
packages/unitables-dmn/src/DmnRunnerOutputsTable.tsx:
##########
@@ -399,8 +399,11 @@ function OutputsBeeTable({ id, i18n, outputsPropertiesMap,
results, scrollablePa
return [BeeTableOperation.SelectionCopy];
}, []);
+ const widthsById = useMemo(() => new Map(), []); // FIXME: Tiago
Review Comment:
🙈
##########
packages/stunner-editors-dmn-loader/src/gwtToBee.ts:
##########
Review Comment:
And this would be `gwtToDmn`
##########
packages/dmn-editor/src/boxedExpressions/getDefaultExpressionDefinitionByLogicType.tsx:
##########
@@ -48,189 +46,189 @@ import {
import {
INVOCATION_EXPRESSION_DEFAULT_PARAMETER_NAME,
INVOCATION_EXPRESSION_DEFAULT_PARAMETER_DATA_TYPE,
- INVOCATION_EXPRESSION_DEFAULT_PARAMETER_LOGIC_TYPE,
} from
"@kie-tools/boxed-expression-component/dist/expressions/InvocationExpression";
import { RELATION_EXPRESSION_DEFAULT_VALUE } from
"@kie-tools/boxed-expression-component/dist/expressions/RelationExpression";
import { DataTypeIndex } from "../dataTypes/DataTypes";
import { isStruct } from "../dataTypes/DataTypeSpec";
+import { DMN15__tContextEntry } from
"@kie-tools/dmn-marshaller/src/schemas/dmn-1_5/ts-gen/types";
Review Comment:
Oh oh... We're not supposed to import from `src` dirs.
##########
packages/stunner-editors-dmn-loader/package.json:
##########
@@ -16,6 +16,7 @@
"@kie-tools-core/monaco-editor": "workspace:*",
"@kie-tools/boxed-expression-component": "workspace:*",
"@kie-tools/dmn-feel-antlr4-parser": "workspace:*",
+ "@kie-tools/dmn-marshaller": "workspace:*",
Review Comment:
👍
##########
packages/scesim-editor/src/table/TestScenarioTable.tsx:
##########
@@ -1121,6 +1121,7 @@ function TestScenarioTable({
shouldRenderRowIndexColumn={!isBackground}
shouldShowColumnsInlineControls={true}
shouldShowRowsInlineControls={!isBackground}
+ widthsById={new Map<string, number[]>()} // The widths in SceSim are
handled direct in the columns
Review Comment:
Can we create a constant here in the global scope? There's really no need
for this new Map to be created every time this component re-renders.
##########
packages/stunner-editors-dmn-loader/src/index.tsx:
##########
@@ -132,38 +143,42 @@ const BoxedExpressionEditorWrapper:
React.FunctionComponent<BoxedExpressionEdito
};
}, [boxedExpressionEditorRootNode]);
+ const onWidthsChange = useCallback(() => {}, []);
Review Comment:
🙈?
##########
packages/unitables/src/bee/UnitablesBeeTable.tsx:
##########
@@ -303,8 +303,11 @@ export function UnitablesBeeTable({
return row.original.id;
}, []);
+ const widthsById = useMemo(() => new Map(), []); // FIXME: Tiago
Review Comment:
🙈?
##########
packages/stunner-editors-dmn-loader/src/Dmn15Spec.ts:
##########
Review Comment:
Not sure why we need this file here...
##########
packages/stunner-editors/kie-wb-common-dmn/kie-wb-common-dmn-client/src/main/java/org/kie/workbench/common/dmn/client/editors/expressions/ExpressionEditorViewImpl.java:
##########
@@ -649,7 +649,7 @@ private String getTypeRef() {
return qName.getLocalPart();
}
- private PMMLParam[] buildPmmlParams() {
+ private PMMLParam[] buildpmmlDocuments() {
Review Comment:
Little typo..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
