tiagobento commented on code in PR #2202:
URL:
https://github.com/apache/incubator-kie-tools/pull/2202#discussion_r1535699369
##########
packages/stunner-editors/kie-wb-common-dmn/kie-wb-common-dmn-client/src/main/java/org/kie/workbench/common/dmn/client/editors/expressions/jsinterop/util/ExpressionPropsFiller.java:
##########
@@ -105,7 +105,7 @@ public static ExpressionProps
buildAndFillJsInteropProp(final Expression wrapped
outputConvertForDecisionTableProps(decisionTableExpression, expressionName,
dataType),
rulesConvertForDecisionTableProps(decisionTableExpression));
}
- return new ExpressionProps(expressionId, expressionName, dataType,
UNDEFINED.getText());
+ return null;
Review Comment:
@danielzhe But we didn't change GWT's implementation, nor the original
ExpressionDefinition interface, right? My point is that converting an Undefined
expression to `null` or `undefined` would be the job for the `mapping.ts`
functions....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
