thiagoelg commented on code in PR #2225: URL: https://github.com/apache/incubator-kie-tools/pull/2225#discussion_r1551766718
########## packages/cors-proxy-image/Containerfile: ########## @@ -17,12 +17,17 @@ FROM --platform=linux/amd64 registry.access.redhat.com/ubi9/ubi-minimal:9.3 +ARG CORS_PROXY_DEFAULT_HTTP_PORT +ARG CORS_PROXY_DEFAULT_ORIGIN +ARG CORS_PROXY_DEFAULT_VERBOSE Review Comment: @Josephblt What do you think about setting a default value for these ARGs? I know we pass them via the `build:*` scripts in our package.json, but setting a default value means we can just run `docker build` and it will work just fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
