tiagobento commented on code in PR #2225:
URL:
https://github.com/apache/incubator-kie-tools/pull/2225#discussion_r1552044789
##########
packages/kie-sandbox-image/package.json:
##########
@@ -24,8 +24,8 @@
"copy:online-editor:linux:darwin": "cp -R ../online-editor/dist
./dist-dev/online-editor",
"copy:online-editor:win32": "pnpm powershell \"Copy-Item -R
../online-editor/dist ./dist-dev/online-editor\"",
"env-json:schema:generate": "ts-json-schema-generator --path
./node_modules/@kie-tools/online-editor/src/env/EnvJson.ts --type EnvJson --id
EnvJson --out ./dist-dev/EnvJson.schema.json",
- "image:docker:build": "kie-tools--image-builder build -r \"$(build-env
kieSandbox.image.registry)\" -a \"$(build-env kieSandbox.image.account)\" -n
\"$(build-env kieSandbox.image.name)\" -t \"$(build-env
kieSandbox.image.buildTags)\"",
- "image:podman:build": "kie-tools--image-builder build -r \"$(build-env
kieSandbox.image.registry)\" -a \"$(build-env kieSandbox.image.account)\" -n
\"$(build-env kieSandbox.image.name)\" -t \"$(build-env
kieSandbox.image.buildTags)\" -e podman"
+ "image:docker:build": "kie-tools--image-builder build -r \"$(build-env
kieSandbox.image.registry)\" -a \"$(build-env kieSandbox.image.account)\" -n
\"$(build-env kieSandbox.image.name)\" -t \"$(build-env
kieSandbox.image.buildTags)\" --build-arg
\"KIE_SANDBOX_DEFAULT_PORT=$(build-env onlineEditor.dev.port)\"",
+ "image:podman:build": "kie-tools--image-builder build -r \"$(build-env
kieSandbox.image.registry)\" -a \"$(build-env kieSandbox.image.account)\" -n
\"$(build-env kieSandbox.image.name)\" -t \"$(build-env
kieSandbox.image.buildTags)\" --build-arg
\"KIE_SANDBOX_DEFAULT_PORT=$(build-env onlineEditor.dev.port)\" -e podman"
Review Comment:
I'd keep the default internal port as 8080...
##########
packages/kie-sandbox-image/package.json:
##########
@@ -24,8 +24,8 @@
"copy:online-editor:linux:darwin": "cp -R ../online-editor/dist
./dist-dev/online-editor",
"copy:online-editor:win32": "pnpm powershell \"Copy-Item -R
../online-editor/dist ./dist-dev/online-editor\"",
"env-json:schema:generate": "ts-json-schema-generator --path
./node_modules/@kie-tools/online-editor/src/env/EnvJson.ts --type EnvJson --id
EnvJson --out ./dist-dev/EnvJson.schema.json",
- "image:docker:build": "kie-tools--image-builder build -r \"$(build-env
kieSandbox.image.registry)\" -a \"$(build-env kieSandbox.image.account)\" -n
\"$(build-env kieSandbox.image.name)\" -t \"$(build-env
kieSandbox.image.buildTags)\"",
- "image:podman:build": "kie-tools--image-builder build -r \"$(build-env
kieSandbox.image.registry)\" -a \"$(build-env kieSandbox.image.account)\" -n
\"$(build-env kieSandbox.image.name)\" -t \"$(build-env
kieSandbox.image.buildTags)\" -e podman"
+ "image:docker:build": "kie-tools--image-builder build -r \"$(build-env
kieSandbox.image.registry)\" -a \"$(build-env kieSandbox.image.account)\" -n
\"$(build-env kieSandbox.image.name)\" -t \"$(build-env
kieSandbox.image.buildTags)\" --build-arg
\"KIE_SANDBOX_DEFAULT_PORT=$(build-env onlineEditor.dev.port)\"",
+ "image:podman:build": "kie-tools--image-builder build -r \"$(build-env
kieSandbox.image.registry)\" -a \"$(build-env kieSandbox.image.account)\" -n
\"$(build-env kieSandbox.image.name)\" -t \"$(build-env
kieSandbox.image.buildTags)\" --build-arg
\"KIE_SANDBOX_DEFAULT_PORT=$(build-env onlineEditor.dev.port)\" -e podman"
Review Comment:
This is not the same, as we're going from 8080 to 9001...
##########
packages/cors-proxy-image/Containerfile:
##########
@@ -17,12 +17,17 @@
FROM --platform=linux/amd64 registry.access.redhat.com/ubi9/ubi-minimal:9.3
+ARG CORS_PROXY_DEFAULT_HTTP_PORT
Review Comment:
Can we use `CORS_PROXY_DEFAULT_PORT` instead of `HTTP_PORT`? I mean, I
prefer `HTTP_PORT`, but all other places have these set as `PORT` only, so
let's keep it consistent...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
