thiagoelg commented on code in PR #2225:
URL:
https://github.com/apache/incubator-kie-tools/pull/2225#discussion_r1562541605
##########
packages/kie-sandbox-distribution/env/index.js:
##########
@@ -67,11 +67,11 @@ module.exports = composeEnv([buildEnv,
extendedServicesImageEnv, corsProxyImageE
description: "",
},
KIE_SANDBOX_DISTRIBUTION__extendedServicesContainerPort: {
- default: "21345",
+ default: extendedServicesImageEnv.env.extendedServicesImage.port,
description: "",
},
KIE_SANDBOX_DISTRIBUTION__extendedServicesExposedPort: {
- default: "21345",
+ default: extendedServicesImageEnv.env.extendedServicesImage.port,
Review Comment:
I think this should be fixed to `21345` or whatever port it was before since
it is the host port.
(Maybe calling these variables `...ExposedPort` was a mistake on my part,
they should be called `...HostPort` to avoid confusion, but we can leave that
for later)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
