tiagobento commented on PR #2195: URL: https://github.com/apache/incubator-kie-tools/pull/2195#issuecomment-2059530658
@fantonangeli Thanks for the changes! This is getting in a very good shape. Please do remove the `DROOLS_version` variable from `root-env` and use the same version of Kogito Runtimes for Drools dependencies. We'll give it a better name in the future, I promise :) As for the maven-base changes on the pom.xml, I think we can list the dependencies at the <dependencyManagement> section so we can refer to them in the <dependencies> of the examples without specifying a version. It will make the pom.xml files of Maven-based packages look a lot nicer, and it will be much easier to maintain too :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
