tiagobento commented on PR #2195: URL: https://github.com/apache/incubator-kie-tools/pull/2195#issuecomment-2061743588
@fantonangeli Since we are introducing a lot of Maven-based packages on this PR, I'm taking the opportunity to make our Maven configurations better here. One point that I need to address is the fact that we're declaring the <parent> using a relative path to the `maven-base` directory. This has the potential of making a package work without declaring a dependency to the `maven-base` package in the package.json. Since `package.json` is the file that controls de build order and everything, we need to use the mechanisms it provides to only access stuff that we declare. Please apply this change not only to the new Maven packages you're creating here, but to other Maven packages declaring `maven-base` as parent: `<relativePath>../../packages/maven-base/pom.xml</relativePath>` becomes `<relativePath>./node_modules/@kie-tools/maven-base/pom.xml</relativePath>` This way, packages that fail to declare `maven-base` as a dependency on their package.json files will throw an error, keeping our build safe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
