fjtirado commented on code in PR #2038:
URL: 
https://github.com/apache/incubator-kie-kogito-apps/pull/2038#discussion_r1572194342


##########
jobs-service/jobs-service-common/src/main/java/org/kie/kogito/jobs/service/repository/marshaller/JobDetailsMarshaller.java:
##########
@@ -99,6 +100,7 @@ public JobDetailsAccessor(JobDetails jobDetails, 
RecipientMarshaller recipientMa
             this.trigger = Optional.ofNullable(jobDetails.getTrigger()).map(t 
-> triggerMarshaller.marshall(t).getMap()).orElse(null);
             this.executionTimeout = jobDetails.getExecutionTimeout();
             this.executionTimeoutUnit = 
Optional.ofNullable(jobDetails.getExecutionTimeoutUnit()).map(Enum::name).orElse(null);
+            this.created = Optional.ofNullable(jobDetails.getCreated()).map(u 
-> Date.from(u.toInstant())).orElse(null);

Review Comment:
   Rather than null, can we return new Date(System.currentTimeMilit) on the 
else? (Im not sure, just wondering)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to