wmedvede commented on code in PR #2038:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2038#discussion_r1573197403
##########
jobs-service/jobs-service-common/src/main/java/org/kie/kogito/jobs/service/repository/marshaller/JobDetailsMarshaller.java:
##########
@@ -99,6 +100,7 @@ public JobDetailsAccessor(JobDetails jobDetails,
RecipientMarshaller recipientMa
this.trigger = Optional.ofNullable(jobDetails.getTrigger()).map(t
-> triggerMarshaller.marshall(t).getMap()).orElse(null);
this.executionTimeout = jobDetails.getExecutionTimeout();
this.executionTimeoutUnit =
Optional.ofNullable(jobDetails.getExecutionTimeoutUnit()).map(Enum::name).orElse(null);
+ this.created = Optional.ofNullable(jobDetails.getCreated()).map(u
-> Date.from(u.toInstant())).orElse(null);
Review Comment:
I believe we shouldn't, because Marshalling/Unmarshalling is an intermediary
processing, if the value is there, good, we process, if not, I believe we
shouldn't invent it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
