tkobayas commented on code in PR #5855:
URL:
https://github.com/apache/incubator-kie-drools/pull/5855#discussion_r1574247653
##########
drools-drl/drools-drl-parser-tests/src/test/java/org/drools/drl/parser/antlr4/DescrCommonPropertyTest.java:
##########
@@ -343,11 +401,18 @@ void windowReferenceDescr() {
" StockTick() from window MyWindow\n" +
" then\n" +
"end";
- final PackageDescr pkg = parser.parse(source);
+ final PackageDescr pkg = parseAndGetPackageDescr(source);
final RuleDescr rule = pkg.getRules().get(0);
PatternDescr pattern = (PatternDescr) rule.getLhs().getDescrs().get(0);
WindowReferenceDescr windowReference = (WindowReferenceDescr)
pattern.getSource();
- assertProperties(windowReference, 35, 49, 3, 21, 3, 35);
+ // Backward Compatibility Notes:
+ // The old DRL6Parser doesn't populate common properties of
WindowReferenceDescr (seem to be wrong).
+ // Backward compatibility doesn't seem to be required in this case.
Review Comment:
`Backward Compatibility Notes` : B) Old parser seems to be wrong
Old parser handles doesn't populate WindowReferenceDescr common properties.
So all `-1`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
