tkobayas commented on code in PR #5855:
URL:
https://github.com/apache/incubator-kie-drools/pull/5855#discussion_r1575695235
##########
drools-drl/drools-drl-parser-tests/pom.xml:
##########
@@ -83,4 +83,42 @@
</dependency>
</dependencies>
+ <profiles>
+ <profile>
+ <id>default</id>
+ <activation>
+ <activeByDefault>true</activeByDefault>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <executions>
+ <execution>
+ <!-- override default-test for new parser -->
+ <id>default-test</id>
+ <configuration>
+ <systemPropertyVariables>
+
<drools.drl.antlr4.parser.enabled>true</drools.drl.antlr4.parser.enabled>
+ </systemPropertyVariables>
+ </configuration>
+ </execution>
+ <execution>
+ <id>old-parser-test</id>
+ <configuration>
+ <systemPropertyVariables>
+
<drools.drl.antlr4.parser.enabled>false</drools.drl.antlr4.parser.enabled>
+ </systemPropertyVariables>
+ </configuration>
+ <goals>
+ <goal>test</goal>
+ </goals>
+ </execution>
Review Comment:
@yurloc Yes, in `drools-drl-parser-tests`, surefire runs twice with
`drools.drl.antlr4.parser.enabled` = `true` and `false`. You would see:
```
[INFO] --- surefire:3.1.2:test (default-test) @ drools-drl-parser-tests ---
[INFO] Using auto detected provider
org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
[INFO]
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.drools.drl.parser.antlr4.DRLExprParserTest
...
### parse : ANTLR4_PARSER_ENABLED = true
### parse : ANTLR4_PARSER_ENABLED = true
...
[INFO]
[INFO] Results:
[INFO]
[WARNING] Tests run: 351, Failures: 0, Errors: 0, Skipped: 17
[INFO]
[INFO]
[INFO] --- surefire:3.1.2:test (old-parser-test) @ drools-drl-parser-tests
---
[INFO] Using auto detected provider
org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
[INFO]
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.drools.drl.parser.antlr4.DRLExprParserTest
...
### parse : ANTLR4_PARSER_ENABLED = false
### parse : ANTLR4_PARSER_ENABLED = false
...
[INFO]
[INFO] Results:
[INFO]
[WARNING] Tests run: 351, Failures: 0, Errors: 0, Skipped: 17
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
