jianrongzhang89 commented on code in PR #467:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/467#discussion_r1607179567
##########
workflowproj/operator.go:
##########
@@ -41,6 +41,8 @@ const (
LabelService = metadata.Domain + "/service"
// LabelWorkflow specialized label managed by the controller
LabelWorkflow = metadata.Domain + "/workflow-app"
+ // LabelWorkflowNamespace specialized label managed by the controller
indicating the namespace of the workflow
+ LabelWorkflowNamespace = metadata.Domain + "/workflow-namespace"
Review Comment:
This is true for most cases, but not for a trigger that is created in a
different namespace and in such case, we need LabelWorkflowNamespace to let the
operator know which namespace the workflow resides, so that it can delete the
trigger when the workflow is removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
