jianrongzhang89 commented on code in PR #467:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/467#discussion_r1607424925
##########
controllers/profiles/common/mutate_visitors.go:
##########
@@ -96,25 +100,47 @@ func EnsureDeployment(original *appsv1.Deployment, object
*appsv1.Deployment) er
object.Spec.Replicas = original.Spec.Replicas
object.Spec.Selector = original.Spec.Selector
object.Labels = original.GetLabels()
+ object.Finalizers = original.Finalizers
// Clean up the volumes, they are inherited from original, additional
are added by other visitors
- object.Spec.Template.Spec.Volumes = nil
+ // However, the knative mount path must be preserved
+ var kneVol *corev1.Volume = nil
Review Comment:
I am not sure how this can be done in another mutator, because the knative
volume is injected by Knative Eventing, not the SonataFlow operator. I moved
the logic into a helper function for readability though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
