treblereel commented on PR #2373: URL: https://github.com/apache/incubator-kie-tools/pull/2373#issuecomment-2142683542
> > > Looks good to me. > > > Just one note: > > > > > > * it is possible to use following command where `namespace` and `skip-namespace` which are mutually exclusive: > > > `kn workflow gen-manifest --namespace "mynamespace" --skip-namespace` > > > * is it the same thing when `namespace` is empty? > > > `kn workflow gen-manifest --namespace="" --skip-namespace` > > > > > > These are non blocking notes. Just thinking if it is ok to have it like this. > > > > > > > > 1. in case of `--namespace "mynamespace" --skip-namespace` --skip-namespace would win > > 2. yeap, as I understand correctly from the issue, --skip-namespace should ack as ` --namespace=""`. Correct me, if I'm wrong please > > A slightly difference here. > > `namespace = ""` is different than stripping the `namespace` attribute from the CR. Not sure how `kubectl` would interpret it, we can test it. But I believe we can remove the `namespace` from the CR when `--skip-namespace` and add the attribute being blank when `-namespace=""`. thank you for the clarification, I'll fix it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
