ricardozanini commented on code in PR #2373:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2373#discussion_r1624781310


##########
packages/kn-plugin-workflow/pkg/command/gen_manifest.go:
##########
@@ -197,3 +233,23 @@ func resolveManifestDir(folderName string) (string, error) 
{
 
        return absPath, nil
 }
+
+func isValidProfile(profile string) error {

Review Comment:
   I'll add this to the operator's API package. Can you please open an issue 
here? https://github.com/apache/incubator-kie-kogito-serverless-operator/



##########
packages/sonataflow-operator/workflowproj/workflowproj.go:
##########
@@ -64,6 +64,8 @@ type WorkflowProjectHandler interface {
        SaveAsKubernetesManifests(path string) error
        // AsObjects returns a reference to the WorkflowProject holding the 
Kubernetes Manifests based on your files.
        AsObjects() (*WorkflowProject, error)
+       // Image overrides the default image in the generated SonataFlow 
manifest
+       Image(image string) WorkflowProjectHandler

Review Comment:
   Can you please also backport this to the operator's repo? 
https://github.com/apache/incubator-kie-kogito-serverless-operator/



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to