jianrongzhang89 commented on code in PR #467:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/467#discussion_r1626844347
##########
controllers/knative/knative.go:
##########
@@ -20,20 +20,37 @@
package knative
import (
+ "context"
+ "fmt"
+
+ operatorapi
"github.com/apache/incubator-kie-kogito-serverless-operator/api/v1alpha08"
+ "github.com/apache/incubator-kie-kogito-serverless-operator/utils"
+ kubeutil
"github.com/apache/incubator-kie-kogito-serverless-operator/utils/kubernetes"
+ appsv1 "k8s.io/api/apps/v1"
+ corev1 "k8s.io/api/core/v1"
+ "k8s.io/apimachinery/pkg/types"
"k8s.io/client-go/discovery"
"k8s.io/client-go/rest"
clienteventingv1
"knative.dev/eventing/pkg/client/clientset/versioned/typed/eventing/v1"
+ duckv1 "knative.dev/pkg/apis/duck/v1"
clientservingv1
"knative.dev/serving/pkg/client/clientset/versioned/typed/serving/v1"
)
var servingClient clientservingv1.ServingV1Interface
var eventingClient clienteventingv1.EventingV1Interface
+var discoveryClient discovery.DiscoveryInterface
type Availability struct {
Eventing bool
Serving bool
}
+const (
+ KSink = "K_SINK"
+ KnativeBundleVolume = "kne-bundle-volume"
+ KCeOverRides = "K_CE_OVERRIDES"
+)
Review Comment:
Good catch. Renamed to be local ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
