jianrongzhang89 commented on PR #467: URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/467#issuecomment-2168597187
> @wmedvede @jianrongzhang89 For the naming problem, let's use `trigger-<randon-id>` as used by pods. Then we just have to make sure that this info is tied to the parent object. If in a workflow, we can add to the `.status.triggers` attribute an array of knative triggers. The same for DI and JS. Then, the name won't be a matter anymore and we have a good way of finding the relation between then. @ricardozanini @wmedvede this is a great idea. This limitation is indeed required by the Knative eventing itself, as it uses a label with the trigger name in the subscription objects. I updated the PR with a slightly different implementation using the knative's function ChildName() to generate the trigger name. It is based on the parent object (data index, job index or workflow)'s UID and make sure that the generated name won't be longer that 63 characters. Here are an example of the trigger names: data-index-jobs-9e8d24ce-5032-4771-9934-da0c15fd69cc data-index-process-definition-73a585bd4a43f0ee289b57dfbedf39dd9 data-index-process-error-9e8d24ce-5032-4771-9934-da0c15fd69cc data-index-process-node-9e8d24ce-5032-4771-9934-da0c15fd69cc data-index-process-sla-9e8d24ce-5032-4771-9934-da0c15fd69cc data-index-process-state-9e8d24ce-5032-4771-9934-da0c15fd69cc data-index-process-variable-5fa0f63cae14d1df1c1bd23aaa599b559e8 jobs-service-create-job-9e8d24ce-5032-4771-9934-da0c15fd69cc jobs-service-delete-job-9e8d24ce-5032-4771-9934-da0c15fd69cc greetingtest5-greetingevent-be7d8bd8dce1feb49e4e476c2842512b8ea greetingtest5-greetingevent2-0a73c1906bdc359d653befc487a9f7048e Since these triggers have labels or owner references that indicate which workflows (or dataindex or job service's) they belong to already, it does not seem to me that we need to add the information to workflow's status. Please let me know if I missed something and this is really required. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
