rgolangh commented on PR #482: URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/482#issuecomment-2154151258
For most of the code path it is easy except the various config maps factories in workflowproj/operator.go I can ignore the platform for those as a compromise On Thu, 6 Jun 2024 at 22:28 Ricardo Zanini ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In controllers/platform/k8s.go > <https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/482#discussion_r1630110990> > : > > > + "app.kubernetes.io/name": psh.GetServiceName(), > + "app.kubernetes.io/component": psh.GetContainerName(), > + "app.kubernetes.io/part-of": platform.Name, > + "app.kubernetes.io/managed-by": "sonataflow-operator", > > Please add these to > https://github.com/apache/incubator-kie-kogito-serverless-operator/blob/main/api/metadata/annotations.go#L22 > ------------------------------ > > In workflowproj/operator.go > <https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/482#discussion_r1630112020> > : > > > @@ -85,8 +85,12 @@ func GetManagedPropertiesFileName(workflow *operatorapi.SonataFlow) string { > // GetDefaultLabels gets the default labels based on the given workflow. > func GetDefaultLabels(workflow *operatorapi.SonataFlow) map[string]string { > return map[string]string{ > - LabelApp: workflow.Name, > - LabelWorkflow: workflow.Name, > + LabelApp: workflow.Name, > + LabelWorkflow: workflow.Name, > + "app.kubernetes.io/name": workflow.Name, > + "app.kubernetes.io/component": "serverless-workflow", > + "app.kubernetes.io/part-of": workflow.Status.Services.DataIndexRef.Url, > > How hard it's to get the platform name here? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/482#pullrequestreview-2103040574>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABGBYHASWTNTNDT2WMCB55TZGCZ7DAVCNFSM6AAAAABI5J3EHWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMBTGA2DANJXGQ> > . > You are receiving this because you were mentioned.Message ID: > <apache/incubator-kie-kogito-serverless-operator/pull/482/review/2103040574 > @github.com> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
