wmedvede commented on code in PR #482:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/482#discussion_r1630728915
##########
workflowproj/operator.go:
##########
@@ -85,8 +85,12 @@ func GetManagedPropertiesFileName(workflow
*operatorapi.SonataFlow) string {
// GetDefaultLabels gets the default labels based on the given workflow.
func GetDefaultLabels(workflow *operatorapi.SonataFlow) map[string]string {
return map[string]string{
- LabelApp: workflow.Name,
- LabelWorkflow: workflow.Name,
+ LabelApp: workflow.Name,
+ LabelWorkflow: workflow.Name,
+ "app.kubernetes.io/name": workflow.Name,
+ "app.kubernetes.io/component": "serverless-workflow",
+ "app.kubernetes.io/part-of":
workflow.Status.Services.DataIndexRef.Url,
Review Comment:
+1 to the platform name if possible at this point. Also, to be part of
"data-index" I see a bit strange. If the jobs-service is present, should it be
part of the jobs-service too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
