jianrongzhang89 commented on PR #467:
URL: 
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/467#issuecomment-2185437962

   > If I rename the broker in the sonataflowplatform, the triggers are not 
updated. ie:
   > 
   > ```
   > eventing:
   >     broker:
   >       ref:
   >         name: kafka-broker
   >         namespace: sonataflow-infra
   >         apiVersion: eventing.knative.dev/v1
   >         kind: Broker
   > ```
   > 
   > Creates the triggers, then I remove `data-index-jobs`. The trigger is not 
re-created automatically, is that normal?
   > 
   > Then I edit the `eventing` spec and I set the broker name to 
`kafka-broker2` and then, only the deleted trigger is (re)created, the other do 
not change:
   > 
   > ```
   > $ oc get trigger -A
   > NAMESPACE      NAME                                                        
      BROKER          SUBSCRIBER_URI   AGE   READY   REASON
   > orchestrator   data-index-jobs-2ac1baab-d856-40bc-bcec-c6dd50951419        
      kafka-broker2                    35s           
   > orchestrator   
data-index-process-definition-634c6f230b6364cdda8272f98c5d58722   kafka-broker  
                   19m           
   > orchestrator   
data-index-process-error-2ac1baab-d856-40bc-bcec-c6dd50951419     kafka-broker  
                   19m           
   > orchestrator   
data-index-process-node-2ac1baab-d856-40bc-bcec-c6dd50951419      kafka-broker  
                   19m           
   > orchestrator   data-index-process-sla-2ac1baab-d856-40bc-bcec-c6dd50951419 
      kafka-broker                     19m           
   > orchestrator   
data-index-process-state-2ac1baab-d856-40bc-bcec-c6dd50951419     kafka-broker  
                   19m           
   > orchestrator   
data-index-process-variable-6f721bf111e75efc394000bca9884ae22ac   kafka-broker  
                   19m           
   > orchestrator   
jobs-service-create-job-2ac1baab-d856-40bc-bcec-c6dd50951419      kafka-broker  
                   19m           
   > orchestrator   
jobs-service-delete-job-2ac1baab-d856-40bc-bcec-c6dd50951419      kafka-broker  
                   19m 
   > ```
   > 
   > I would expect all triggers (and sinkbindings) to be recreated with the 
new value
   > 
   > Similarly, if I delete the sinkbinding, it is not automatically re-created
   
   Fix is done so that when a sinkbinding or trigger is deleted, it will get 
recreated by the operator.
   However, when the sonataflowplatform broker name is updated, the trigger's 
broker won't get updated because the trigger broker name is immutable in 
Knative. In this case, an error will be generated in the operator logs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to