fjtirado commented on PR #3572: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3572#issuecomment-2223031307
> Hi @fjtirado Thanks for the PR. Anyway, beside other issue, I think it would be better to avoid usage of "String" for "paths". We had a lot of issues over the last years exactly for that, and I'm afraid that this modification could bring back them, sooner or later. Maybe, `java.nio.file.Path` (or similar high-level API) could be used, that automatically take care of the underlyng OS ? Sure, Path were already being used in FileContentLoader. The change in this PR is for using String rather than URI in URIContentLoaderFactory. URIContentLoaderFactory then parse the String and create and HTTPContentLoader, FileContentLoader or ClasspathContentLoader. FileContentLoader, which leads with files, were already using Path (but now, rathern than obtaining the Path from the URI, it obtains it from the String) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
