fjtirado commented on code in PR #3572:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3572#discussion_r1675685455
##########
kogito-serverless-workflow/kogito-serverless-workflow-builder/src/main/java/org/kie/kogito/serverless/workflow/io/URIContentLoaderFactory.java:
##########
@@ -85,25 +64,29 @@ public static byte[] readBytes(String uriStr, Workflow
workflow, ParserContext p
}
public static byte[] readBytes(String uriStr, Workflow workflow,
Optional<ParserContext> parserContext) {
- return readAllBytes(buildLoader(URI.create(uriStr), workflow,
parserContext, null));
+ return readAllBytes(buildLoader(uriStr, workflow, parserContext,
null));
}
public static Builder builder(URI uri) {
Review Comment:
As explained in Zulip, this public one I would keep in case I switch the
implementaiton again to URI in a future where this class is portable across OS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
