ljmotta commented on code in PR #2462:
URL:
https://github.com/apache/incubator-kie-tools/pull/2462#discussion_r1678414956
##########
packages/dmn-editor/tests-e2e/drds/modelDecisionServicesInDrds.spec.ts:
##########
Review Comment:
I guess this file is still a WIP?
##########
packages/dmn-editor/tests-e2e/__fixtures__/nodes.ts:
##########
@@ -163,15 +163,15 @@ export class Nodes {
await this.page.mouse.up();
}
- public async select(args: { name: string; position?: NodePosition }) {
+ public async select(args: { name: string; position?: NodePosition;
dblClick?: boolean }) {
const node = this.get({ name: args.name });
const position =
args.position !== undefined
? await this.getPositionalNodeHandleCoordinates({ node, position:
args.position })
: undefined;
- await node.click({ position });
+ args.dblClick ? await node.dblclick({ position }) : await node.click({
position });
Review Comment:
To select a node only one click is required. Why adding the option to select
with double click?
##########
packages/dmn-editor/src/diagram/Palette.tsx:
##########
@@ -221,11 +225,16 @@ export function Palette({ pulse }: { pulse: boolean }) {
<br />
<aside className={"kie-dmn-editor--drg-panel-toggle"}>
{diagram.openLhsPanel === DiagramLhsPanel.DRG_NODES && (
- <div className={"kie-dmn-editor--palette-nodes-popover"} style={{
maxHeight }}>
+ <div
+ data-testid={"kie-tools--dmn-editor--palette-nodes-popover"}
+ className={"kie-dmn-editor--palette-nodes-popover"}
+ style={{ maxHeight }}
+ >
<DrgNodesPanel />
</div>
)}
<button
+ data-testid={"kie-tools--dmn-editor--drg-panel-toggle-button"}
Review Comment:
This `data-testid` is required? Even with the `DRG nodes` title?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
