ljmotta commented on code in PR #2462:
URL:
https://github.com/apache/incubator-kie-tools/pull/2462#discussion_r1683197149
##########
packages/dmn-editor/tests-e2e/__fixtures__/nodes.ts:
##########
@@ -163,15 +163,15 @@ export class Nodes {
await this.page.mouse.up();
}
- public async select(args: { name: string; position?: NodePosition }) {
+ public async select(args: { name: string; position?: NodePosition;
dblClick?: boolean }) {
const node = this.get({ name: args.name });
const position =
args.position !== undefined
? await this.getPositionalNodeHandleCoordinates({ node, position:
args.position })
: undefined;
- await node.click({ position });
+ args.dblClick ? await node.dblclick({ position }) : await node.click({
position });
Review Comment:
Alright, so we have a problem here. The `select` should select the node,
which is accomplished with one click. Adding more functionalities to it will
hide what we're actually doing here, which is enter in edit mode. Now, if we
have another way of selecting the node, we can add to this method. But for this
case we want to enter on edit mode for the node name, and we can do that with
some alternative ways, which should be encapsulated on another method. I mean,
we can do that with `dbclick` and `click+enter` (select + enter).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
