Re: [PR] Set recommended kubernetes labels on services and workflows [incubator-kie-kogito-serverless-operator]

Fri, 19 Jul 2024 06:41:03 -0700 


wmedvede commented on PR #482:
URL: 
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/482#issuecomment-2239210351

   Hi @rgolangh , great work, many thanks.
   
   Here goes some nitpicks I could find doing piece of testing. 
   
   **Pod for a WF deployed with preview profile**
   
   ![Part-of-preview-Screenshot from 2024-07-19 
14-49-09](https://github.com/user-attachments/assets/0f1d9f18-a63d-4695-b8aa-c683a3020a4e)
   
   **Pod for a WF deployed with the dev profile**
   
   ![Part-of-devmode-Screenshot from 2024-07-19 
14-49-31](https://github.com/user-attachments/assets/66d9ddc6-a203-4bfc-93a6-67e39af7280c)
   
   
   ^ I couldn't check the gitops profile, please verify.
   
   
   **Config maps for DI and JS**
   
   ![Config-map-for-sevices-Screenshot from 2024-07-19 
14-55-05](https://github.com/user-attachments/assets/3471fb56-2fcf-4e66-b859-baaa873a8a94)
   
   **This is the config map for a workflow**
   
   ![Config-maps-workflow-1-Screenshot from 2024-07-19 
14-56-54](https://github.com/user-attachments/assets/6be3c889-b90b-4026-83b7-b1f73464d2a7)
   
   **Managed properties config map**
   
   ![Config-maps-workflow2-Screenshot from 2024-07-19 
15-00-07](https://github.com/user-attachments/assets/73e02f7d-3285-4679-9551-ad025d7fe894)
   
   **Workflow deployed with the dev profile, both config maps was created by 
the operator:**
   
   ![Config-map-created-by-operator-Screenshot from 2024-07-19 
15-08-01](https://github.com/user-attachments/assets/75cdd401-6afb-40f0-9d17-31227c5d5998)
   
   **But the managed properties for same WF, no labels.**
   ![Config-map-created-by-operator-Screenshot from 2024-07-19 
15-10-25](https://github.com/user-attachments/assets/ff601e80-3fa5-4a0d-9f72-6e8278c69de3)
   
   
   **When we create a WF with the dev profile, a route is created for it**
   
   ![Route-dev-mode-Screenshot from 2024-07-19 
15-04-23](https://github.com/user-attachments/assets/6ac9e0d4-7d07-4d48-83bc-e151aafcd71f)
   
   **Labels for builds**
   When a WF is created in Openshift with the preview mode, the following 
objects are created.
   
   ![A-build-config-Screenshot from 2024-07-19 
15-26-36](https://github.com/user-attachments/assets/4b25e21c-ec04-444d-b9df-da78399c9cdb)
   
   
   ![A-potential-build-Screenshot from 2024-07-19 
15-28-27](https://github.com/user-attachments/assets/02713766-1a0b-48f6-b3b5-6e6878048a3f)
   
   ![A-potential-image-stream-Screenshot from 2024-07-19 
15-30-45](https://github.com/user-attachments/assets/580832a5-5922-459d-8717-6ee0bdeb8f15)
   
   
   ![A-pod-build-Screenshot from 2024-07-19 
15-36-18](https://github.com/user-attachments/assets/46bb99cf-4f73-4878-ba22-7d14fa2edae8)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to