martinweiler commented on code in PR #3597:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3597#discussion_r1700782397
##########
jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/DataTest.java:
##########
@@ -166,157 +201,152 @@ public void testXpathExpression() throws Exception {
@Test
public void testDataInputAssociations() throws Exception {
- kruntime =
createKogitoProcessRuntime("org/jbpm/bpmn2/data/BPMN2-DataInputAssociations.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human
Task",
- new KogitoWorkItemHandler() {
- @Override
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- @Override
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
-
assertThat(workItem.getParameter("coId")).isEqualTo("hello world");
- }
- });
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new
KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem,
KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem,
KogitoWorkItemManager mgr) {
+ assertThat(workItem.getParameter("coId")).isEqualTo("hello
world");
+ }
+ });
+
Document document = DocumentBuilderFactory
.newInstance()
.newDocumentBuilder()
- .parse(new ByteArrayInputStream("<user hello='hello world' />"
- .getBytes()));
- Map<String, Object> params = new HashMap<>();
- params.put("instanceMetadata", document.getFirstChild());
- KogitoProcessInstance processInstance =
kruntime.startProcess("DataInputAssociations", params);
+ .parse(new ByteArrayInputStream("<user hello='hello world'
/>".getBytes()));
+ org.kie.kogito.process.Process<DataInputAssociationsModel>
processDefinition = DataInputAssociationsProcess.newProcess(app);
+ DataInputAssociationsModel model = processDefinition.createModel();
+ model.setInstanceMetadata(document.getFirstChild());
+
+ org.kie.kogito.process.ProcessInstance<DataInputAssociationsModel>
instance = processDefinition.createInstance(model);
+ instance.start();
}
@Test
- public void testDataInputAssociationsWithStringObject() throws Exception {
- kruntime =
createKogitoProcessRuntime("org/jbpm/bpmn2/data/BPMN2-DataInputAssociationsStringObject.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human
Task",
- new KogitoWorkItemHandler() {
-
- @Override
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- @Override
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
-
assertThat(workItem.getParameter("coId")).isEqualTo("hello");
- }
-
- });
- Map<String, Object> params = new HashMap<>();
- params.put("instanceMetadata", "hello");
- KogitoProcessInstance processInstance =
kruntime.startProcess("DataInputAssociationsStringObject", params);
-
+ public void testDataInputAssociationsWithStringObject() {
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new
KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem,
KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem,
KogitoWorkItemManager mgr) {
+ assertThat(workItem.getParameter("coId")).isEqualTo("hello");
+ }
+ });
+
+ org.kie.kogito.process.Process<DataInputAssociationsStringObjectModel>
processDefinition = DataInputAssociationsStringObjectProcess.newProcess(app);
+ DataInputAssociationsStringObjectModel model =
processDefinition.createModel();
+ model.setInstanceMetadata("hello");
+
+
org.kie.kogito.process.ProcessInstance<DataInputAssociationsStringObjectModel>
instance = processDefinition.createInstance(model);
+ instance.start();
}
/**
* TODO testDataInputAssociationsWithLazyLoading
*/
@Test
@Disabled
Review Comment:
We should try to make the disabled tests work. If there is a functional gap,
then this should be captured in JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
