Abhitocode commented on code in PR #3597:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3597#discussion_r1701976982
##########
jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/DataTest.java:
##########
@@ -166,311 +200,281 @@ public void testXpathExpression() throws Exception {
@Test
public void testDataInputAssociations() throws Exception {
- kruntime =
createKogitoProcessRuntime("org/jbpm/bpmn2/data/BPMN2-DataInputAssociations.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human
Task",
- new KogitoWorkItemHandler() {
- @Override
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- @Override
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
-
assertThat(workItem.getParameter("coId")).isEqualTo("hello world");
- }
- });
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new
KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem,
KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem,
KogitoWorkItemManager mgr) {
+ assertThat(workItem.getParameter("coId")).isEqualTo("hello
world");
+ }
+ });
+
Document document = DocumentBuilderFactory
.newInstance()
.newDocumentBuilder()
- .parse(new ByteArrayInputStream("<user hello='hello world' />"
- .getBytes()));
- Map<String, Object> params = new HashMap<>();
- params.put("instanceMetadata", document.getFirstChild());
- KogitoProcessInstance processInstance =
kruntime.startProcess("DataInputAssociations", params);
+ .parse(new ByteArrayInputStream("<user hello='hello world'
/>".getBytes()));
+ org.kie.kogito.process.Process<DataInputAssociationsModel>
processDefinition = DataInputAssociationsProcess.newProcess(app);
+ DataInputAssociationsModel model = processDefinition.createModel();
+ model.setInstanceMetadata(document.getFirstChild());
+
+ org.kie.kogito.process.ProcessInstance<DataInputAssociationsModel>
instance = processDefinition.createInstance(model);
+ instance.start();
}
@Test
- public void testDataInputAssociationsWithStringObject() throws Exception {
- kruntime =
createKogitoProcessRuntime("org/jbpm/bpmn2/data/BPMN2-DataInputAssociationsStringObject.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human
Task",
- new KogitoWorkItemHandler() {
-
- @Override
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- @Override
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
-
assertThat(workItem.getParameter("coId")).isEqualTo("hello");
- }
-
- });
- Map<String, Object> params = new HashMap<>();
- params.put("instanceMetadata", "hello");
- KogitoProcessInstance processInstance =
kruntime.startProcess("DataInputAssociationsStringObject", params);
-
+ public void testDataInputAssociationsWithStringObject() {
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new
KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem,
KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem,
KogitoWorkItemManager mgr) {
+ assertThat(workItem.getParameter("coId")).isEqualTo("hello");
+ }
+ });
+
+ org.kie.kogito.process.Process<DataInputAssociationsStringObjectModel>
processDefinition = DataInputAssociationsStringObjectProcess.newProcess(app);
+ DataInputAssociationsStringObjectModel model =
processDefinition.createModel();
+ model.setInstanceMetadata("hello");
+
+
org.kie.kogito.process.ProcessInstance<DataInputAssociationsStringObjectModel>
instance = processDefinition.createInstance(model);
+ instance.start();
}
/**
* TODO testDataInputAssociationsWithLazyLoading
*/
@Test
- @Disabled
- public void testDataInputAssociationsWithLazyLoading()
- throws Exception {
- kruntime =
createKogitoProcessRuntime("org/jbpm/bpmn2/data/BPMN2-DataInputAssociationsLazyCreating.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human
Task",
- new KogitoWorkItemHandler() {
-
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- Element coIdParamObj = (Element)
workItem.getParameter("coId");
-
assertThat(coIdParamObj.getNodeName()).isEqualTo("mydoc");
-
assertThat(coIdParamObj.getFirstChild().getNodeName()).isEqualTo("mynode");
-
assertThat(coIdParamObj.getFirstChild().getFirstChild().getNodeName()).isEqualTo("user");
-
assertThat(coIdParamObj.getFirstChild().getFirstChild().getAttributes().getNamedItem("hello").getNodeValue()).isEqualTo("hello
world");
- }
-
- });
+ public void testDataInputAssociationsWithLazyLoading() throws Exception {
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new
KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem,
KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem,
KogitoWorkItemManager mgr) {
+ Element coIdParamObj = (Element) workItem.getParameter("coId");
+ assertThat(coIdParamObj.getNodeName()).isEqualTo("mydoc");
+
assertThat(coIdParamObj.getFirstChild().getNodeName()).isEqualTo("mynode");
+
assertThat(coIdParamObj.getFirstChild().getFirstChild().getNodeName()).isEqualTo("user");
+
assertThat(coIdParamObj.getFirstChild().getFirstChild().getAttributes().getNamedItem("hello").getNodeValue()).isEqualTo("hello
world");
+ }
+ });
+
Document document = DocumentBuilderFactory
.newInstance()
.newDocumentBuilder()
- .parse(new ByteArrayInputStream("<user hello='hello world' />"
- .getBytes()));
+ .parse(new ByteArrayInputStream("<user hello='hello world'
/>".getBytes()));
Map<String, Object> params = new HashMap<>();
params.put("instanceMetadata", document.getFirstChild());
- KogitoProcessInstance processInstance =
kruntime.startProcess("DataInputAssociationsLazyCreating", params);
+ org.kie.kogito.process.Process<DataInputAssociationsLazyCreatingModel>
processDefinition = DataInputAssociationsLazyCreatingProcess.newProcess(app);
+ DataInputAssociationsLazyCreatingModel model =
processDefinition.createModel();
+ model.setInstanceMetadata(document.getFirstChild());
+
+
org.kie.kogito.process.ProcessInstance<DataInputAssociationsLazyCreatingModel>
instance = processDefinition.createInstance(model);
+ instance.start();
}
@Test
- public void testDataInputAssociationsWithString() throws Exception {
- kruntime =
createKogitoProcessRuntime("org/jbpm/bpmn2/data/BPMN2-DataInputAssociationsString.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human
Task",
- new KogitoWorkItemHandler() {
-
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
+ public void testDataInputAssociationsWithString() {
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new
KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem,
KogitoWorkItemManager mgr) {
+ }
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
-
assertThat(workItem.getParameter("coId")).isEqualTo("hello");
- }
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem,
KogitoWorkItemManager mgr) {
+ assertThat(workItem.getParameter("coId")).isEqualTo("hello");
+ }
+ });
- });
- KogitoProcessInstance processInstance =
kruntime.startProcess("DataInputAssociationsString");
+ org.kie.kogito.process.Process<DataInputAssociationsStringModel>
processDefinition = DataInputAssociationsStringProcess.newProcess(app);
+ DataInputAssociationsStringModel model =
processDefinition.createModel();
+
org.kie.kogito.process.ProcessInstance<DataInputAssociationsStringModel>
instance = processDefinition.createInstance(model);
+ instance.start();
}
@Test
- public void testDataInputAssociationsWithStringWithoutQuotes()
- throws Exception {
- kruntime =
createKogitoProcessRuntime("org/jbpm/bpmn2/data/BPMN2-DataInputAssociationsStringNoQuotes.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human
Task",
- new KogitoWorkItemHandler() {
-
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
+ public void testDataInputAssociationsWithStringWithoutQuotes() {
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new
KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem,
KogitoWorkItemManager mgr) {
+ }
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
-
assertThat(workItem.getParameter("coId")).isEqualTo("hello");
- }
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem,
KogitoWorkItemManager mgr) {
+ assertThat(workItem.getParameter("coId")).isEqualTo("hello");
+ }
+ });
- });
- KogitoProcessInstance processInstance =
kruntime.startProcess("DataInputAssociationsStringNoQuotes");
+
org.kie.kogito.process.Process<DataInputAssociationsStringNoQuotesModel>
processDefinition = DataInputAssociationsStringNoQuotesProcess.newProcess(app);
+ DataInputAssociationsStringNoQuotesModel model =
processDefinition.createModel();
+
org.kie.kogito.process.ProcessInstance<DataInputAssociationsStringNoQuotesModel>
instance = processDefinition.createInstance(model);
+ instance.start();
}
@Test
- public void testDataInputAssociationsWithXMLLiteral() throws Exception {
- kruntime =
createKogitoProcessRuntime("org/jbpm/bpmn2/data/BPMN2-DataInputAssociationsXmlLiteral.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human
Task",
- new KogitoWorkItemHandler() {
-
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- assertThat(((org.w3c.dom.Node)
workItem.getParameter("coId")).getNodeName()).isEqualTo("id");
- assertThat(((org.w3c.dom.Node)
workItem.getParameter("coId")).getFirstChild().getTextContent()).isEqualTo("some
text");
- }
-
- });
- KogitoProcessInstance processInstance =
kruntime.startProcess("DataInputAssociationsXmlLiteral");
-
+ public void testDataInputAssociationsWithXMLLiteral() {
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new
KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem,
KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem,
KogitoWorkItemManager mgr) {
+ assertThat(((org.w3c.dom.Node)
workItem.getParameter("coId")).getNodeName()).isEqualTo("id");
+ assertThat(((org.w3c.dom.Node)
workItem.getParameter("coId")).getFirstChild().getTextContent()).isEqualTo("some
text");
+ }
+ });
+
+ org.kie.kogito.process.Process<DataInputAssociationsXmlLiteralModel>
processDefinition = DataInputAssociationsXmlLiteralProcess.newProcess(app);
+ DataInputAssociationsXmlLiteralModel model =
processDefinition.createModel();
+
+
org.kie.kogito.process.ProcessInstance<DataInputAssociationsXmlLiteralModel>
instance = processDefinition.createInstance(model);
+ instance.start();
}
/**
* TODO testDataInputAssociationsWithTwoAssigns
*/
@Test
- @Disabled
public void testDataInputAssociationsWithTwoAssigns() throws Exception {
- kruntime =
createKogitoProcessRuntime("BPMN2-DataInputAssociations-two-assigns.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human
Task",
- new KogitoWorkItemHandler() {
-
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- assertThat(((Element)
workItem.getParameter("Comment")).getNodeName()).isEqualTo("foo");
- // assertEquals("mynode", ((Element)
- //
workItem.getParameter("Comment")).getFirstChild().getNodeName());
- // assertEquals("user", ((Element)
- //
workItem.getParameter("Comment")).getFirstChild().getFirstChild().getNodeName());
- // assertEquals("hello world", ((Element)
- //
workItem.getParameter("coId")).getFirstChild().getFirstChild().getAttributes().getNamedItem("hello").getNodeValue());
- }
-
- });
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new
KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem,
KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem,
KogitoWorkItemManager mgr) {
+ assertThat(((Element)
workItem.getParameter("Comment")).getNodeName()).isEqualTo("foo");
+ // assertEquals("mynode", ((Element)
workItem.getParameter("Comment")).getFirstChild().getNodeName());
+ // assertEquals("user", ((Element)
workItem.getParameter("Comment")).getFirstChild().getFirstChild().getNodeName());
+ // assertEquals("hello world", ((Element)
workItem.getParameter("coId")).getFirstChild().getFirstChild().getAttributes().getNamedItem("hello").getNodeValue());
Review Comment:
the tests passes though uncommented but might be commented as invoking
.getNodeName() on null leads to npe.
[INFO] Running org.jbpm.bpmn2.DataTest
org.jbpm.workflow.instance.WorkflowRuntimeException:
[DataInputAssociationsTwoAssigns:b065ee88-e816-4dab-
F]] -- Cannot invoke "org.w3c.dom.Element.getNodeName()" because the return
value of
"org.kie.kogito.internal.process.runtime.KogitoWorkItem.getParameter(String)"
is null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
