Abhitocode commented on code in PR #3596:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3596#discussion_r1700889245
##########
jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/EndEventTest.java:
##########
@@ -95,93 +119,94 @@ public void produce(KogitoProcessInstance pi, String
eventData) {
@Test
@Disabled("On Exit not supported, see
https://issues.redhat.com/browse/KOGITO-2067";)
- public void testOnEntryExitScript() throws Exception {
- kruntime =
createKogitoProcessRuntime("BPMN2-OnEntryExitScriptProcess.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("MyTask",
- new SystemOutWorkItemHandler());
+ public void testOnEntryExitScript() {
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "MyTask", new
SystemOutWorkItemHandler());
+ org.kie.kogito.process.Process<OnEntryExitScriptProcessModel> process
= OnEntryExitScriptProcessProcess.newProcess(app);
+ OnEntryExitScriptProcessModel model = process.createModel();
List<String> myList = new ArrayList<>();
- kruntime.getKieSession().setGlobal("list", myList);
- KogitoProcessInstance processInstance = kruntime
- .startProcess("OnEntryExitScriptProcess");
- assertProcessInstanceCompleted(processInstance);
+ model.setList(myList);
+ ProcessInstance<OnEntryExitScriptProcessModel> processInstance =
process.createInstance(model);
+ processInstance.start();
+
assertThat(processInstance.status()).isEqualTo(org.jbpm.process.instance.ProcessInstance.STATE_COMPLETED);
assertThat(myList).hasSize(4);
-
}
@Test
@Disabled("On Exit not supported, see
https://issues.redhat.com/browse/KOGITO-2067";)
- public void testOnEntryExitNamespacedScript() throws Exception {
- kruntime =
createKogitoProcessRuntime("BPMN2-OnEntryExitNamespacedScriptProcess.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("MyTask",
- new SystemOutWorkItemHandler());
+ public void testOnEntryExitNamespacedScript() {
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "MyTask", new
SystemOutWorkItemHandler());
+
org.kie.kogito.process.Process<OnEntryExitNamespacedScriptProcessModel> process
= OnEntryExitNamespacedScriptProcessProcess.newProcess(app);
+ OnEntryExitNamespacedScriptProcessModel model = process.createModel();
List<String> myList = new ArrayList<>();
- kruntime.getKieSession().setGlobal("list", myList);
- KogitoProcessInstance processInstance = kruntime
- .startProcess("OnEntryExitScriptProcess");
- assertProcessInstanceCompleted(processInstance);
+ model.setList(myList);
+ ProcessInstance<OnEntryExitNamespacedScriptProcessModel>
processInstance = process.createInstance(model);
+ processInstance.start();
+
assertThat(processInstance.status()).isEqualTo(org.jbpm.process.instance.ProcessInstance.STATE_COMPLETED);
assertThat(myList).hasSize(4);
-
}
@Test
@Disabled("On Exit not supported, see
https://issues.redhat.com/browse/KOGITO-2067";)
- public void testOnEntryExitMixedNamespacedScript() throws Exception {
- kruntime =
createKogitoProcessRuntime("BPMN2-OnEntryExitMixedNamespacedScriptProcess.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("MyTask",
- new SystemOutWorkItemHandler());
+ public void testOnEntryExitMixedNamespacedScript() {
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "MyTask", new
SystemOutWorkItemHandler());
+
org.kie.kogito.process.Process<OnEntryExitMixedNamespacedScriptProcessModel>
process = OnEntryExitMixedNamespacedScriptProcessProcess.newProcess(app);
+ OnEntryExitMixedNamespacedScriptProcessModel model =
process.createModel();
List<String> myList = new ArrayList<>();
- kruntime.getKieSession().setGlobal("list", myList);
- KogitoProcessInstance processInstance = kruntime
- .startProcess("OnEntryExitScriptProcess");
- assertProcessInstanceCompleted(processInstance);
+ model.setList(myList);
+ ProcessInstance<OnEntryExitMixedNamespacedScriptProcessModel>
processInstance = process.createInstance(model);
+ processInstance.start();
+
assertThat(processInstance.status()).isEqualTo(org.jbpm.process.instance.ProcessInstance.STATE_COMPLETED);
assertThat(myList).hasSize(4);
-
}
@Test
@Disabled("On Exit not supported, see
https://issues.redhat.com/browse/KOGITO-2067";)
- public void testOnEntryExitScriptDesigner() throws Exception {
- kruntime =
createKogitoProcessRuntime("BPMN2-OnEntryExitDesignerScriptProcess.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("MyTask",
- new SystemOutWorkItemHandler());
+ public void testOnEntryExitScriptDesigner() {
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "MyTask", new
SystemOutWorkItemHandler());
+ org.kie.kogito.process.Process<OnEntryExitDesignerScriptProcessModel>
process = OnEntryExitDesignerScriptProcessProcess.newProcess(app);
+ OnEntryExitDesignerScriptProcessModel model = process.createModel();
List<String> myList = new ArrayList<>();
- kruntime.getKieSession().setGlobal("list", myList);
- KogitoProcessInstance processInstance = kruntime
- .startProcess("OnEntryExitScriptProcess");
- assertProcessInstanceCompleted(processInstance);
+ model.setList(myList);
+ ProcessInstance<OnEntryExitDesignerScriptProcessModel> processInstance
= process.createInstance(model);
+ processInstance.start();
+
assertThat(processInstance.status()).isEqualTo(org.kie.kogito.process.ProcessInstance.STATE_COMPLETED);
assertThat(myList).hasSize(4);
-
}
@Test
- public void testTerminateWithinSubprocessEnd() throws Exception {
- kruntime =
createKogitoProcessRuntime("org/jbpm/bpmn2/event//BPMN2-SubprocessWithParallelSplitTerminate.bpmn2");
- KogitoProcessInstance processInstance =
kruntime.startProcess("SubprocessWithParallelSplitTerminate");
-
- kruntime.signalEvent("signal1", null, processInstance.getStringId());
-
- assertProcessInstanceCompleted(processInstance);
-
+ public void testTerminateWithinSubprocessEnd() {
+ Application app = ProcessTestHelper.newApplication();
+
org.kie.kogito.process.Process<SubprocessWithParallelSplitTerminateModel>
process = SubprocessWithParallelSplitTerminateProcess.newProcess(app);
+ SubprocessWithParallelSplitTerminateModel model =
process.createModel();
+ ProcessInstance<SubprocessWithParallelSplitTerminateModel>
processInstance = process.createInstance(model);
+ processInstance.start();
+ processInstance.send(Sig.of("signal1", null));
+
assertThat(processInstance.status()).isEqualTo(org.kie.kogito.process.ProcessInstance.STATE_COMPLETED);
}
@Test
- public void testTerminateEnd() throws Exception {
- kruntime =
createKogitoProcessRuntime("org/jbpm/bpmn2/event/BPMN2-ParallelSplitTerminate.bpmn2");
- KogitoProcessInstance processInstance =
kruntime.startProcess("ParallelSplitTerminate");
-
- kruntime.signalEvent("Signal 1", null, processInstance.getStringId());
-
- assertProcessInstanceCompleted(processInstance);
-
+ public void testTerminateEnd() {
+ Application app = ProcessTestHelper.newApplication();
+ org.kie.kogito.process.Process<ParallelSplitTerminateModel> process =
ParallelSplitTerminateProcess.newProcess(app);
+ ParallelSplitTerminateModel model = process.createModel();
+ ProcessInstance<ParallelSplitTerminateModel> processInstance =
process.createInstance(model);
+ processInstance.start();
+ processInstance.send(Sig.of("Signal 1", null));
+
assertThat(processInstance.status()).isEqualTo(org.kie.kogito.process.ProcessInstance.STATE_COMPLETED);
}
@Test
- public void testSignalEndWithData() throws Exception {
- kruntime =
createKogitoProcessRuntime("org/jbpm/bpmn2/event/BPMN2-EndEventSignalWithData.bpmn2");
- Map<String, Object> params = new HashMap<>();
- KogitoProcessInstance processInstance =
kruntime.startProcess("EndEventSignalWithData", params);
-
- assertProcessInstanceCompleted(processInstance);
+ public void testSignalEndWithData() {
+ Application app = ProcessTestHelper.newApplication();
+ org.kie.kogito.process.Process<EndEventSignalWithDataModel> process =
EndEventSignalWithDataProcess.newProcess(app);
+ EndEventSignalWithDataModel model = process.createModel();
+ ProcessInstance<EndEventSignalWithDataModel> processInstance =
process.createInstance(model);
+ processInstance.start();
+
assertThat(processInstance.status()).isEqualTo(org.jbpm.process.instance.ProcessInstance.STATE_COMPLETED);
Review Comment:
Will go through the test again and update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
