Abhitocode commented on code in PR #3596:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3596#discussion_r1701273422
##########
jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/EndEventTest.java:
##########
@@ -19,58 +19,82 @@
package org.jbpm.bpmn2;
import java.util.ArrayList;
-import java.util.HashMap;
import java.util.List;
-import java.util.Map;
+import org.jbpm.bpmn2.escalation.EscalationEndEventModel;
+import org.jbpm.bpmn2.escalation.EscalationEndEventProcess;
+import org.jbpm.bpmn2.event.EndEventSignalWithDataModel;
+import org.jbpm.bpmn2.event.EndEventSignalWithDataProcess;
+import org.jbpm.bpmn2.event.ErrorEndEventModel;
+import org.jbpm.bpmn2.event.ErrorEndEventProcess;
import org.jbpm.bpmn2.event.MessageEndEventModel;
import org.jbpm.bpmn2.event.MessageEndEventProcess;
+import org.jbpm.bpmn2.event.OnEntryExitDesignerScriptProcessModel;
+import org.jbpm.bpmn2.event.OnEntryExitDesignerScriptProcessProcess;
+import org.jbpm.bpmn2.event.OnEntryExitMixedNamespacedScriptProcessModel;
+import org.jbpm.bpmn2.event.OnEntryExitMixedNamespacedScriptProcessProcess;
+import org.jbpm.bpmn2.event.OnEntryExitNamespacedScriptProcessModel;
+import org.jbpm.bpmn2.event.OnEntryExitNamespacedScriptProcessProcess;
+import org.jbpm.bpmn2.event.OnEntryExitScriptProcessModel;
+import org.jbpm.bpmn2.event.OnEntryExitScriptProcessProcess;
+import org.jbpm.bpmn2.event.ParallelSplitModel;
+import org.jbpm.bpmn2.event.ParallelSplitProcess;
+import org.jbpm.bpmn2.event.ParallelSplitTerminateModel;
+import org.jbpm.bpmn2.event.ParallelSplitTerminateProcess;
+import org.jbpm.bpmn2.event.SignalEndEventModel;
+import org.jbpm.bpmn2.event.SignalEndEventProcess;
+import org.jbpm.bpmn2.event.SubprocessWithParallelSplitTerminateModel;
+import org.jbpm.bpmn2.event.SubprocessWithParallelSplitTerminateProcess;
import org.jbpm.process.instance.impl.demo.SystemOutWorkItemHandler;
import org.jbpm.test.utils.ProcessTestHelper;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.kie.kogito.Application;
import org.kie.kogito.event.impl.MessageProducer;
import org.kie.kogito.internal.process.runtime.KogitoProcessInstance;
+import org.kie.kogito.process.ProcessInstance;
+import org.kie.kogito.process.impl.Sig;
import static org.assertj.core.api.Assertions.assertThat;
public class EndEventTest extends JbpmBpmn2TestCase {
@Test
- public void testImplicitEndParallel() throws Exception {
- kruntime =
createKogitoProcessRuntime("org/jbpm/bpmn2/event/BPMN2-ParallelSplit.bpmn2");
- KogitoProcessInstance processInstance =
kruntime.startProcess("ParallelSplit");
- assertProcessInstanceCompleted(processInstance);
-
+ public void testImplicitEndParallel() {
+ Application app = ProcessTestHelper.newApplication();
+ org.kie.kogito.process.Process<ParallelSplitModel> process =
ParallelSplitProcess.newProcess(app);
+ ProcessInstance<ParallelSplitModel> processInstance =
process.createInstance(process.createModel());
+ processInstance.start();
+
assertThat(processInstance.status()).isEqualTo(org.jbpm.process.instance.ProcessInstance.STATE_COMPLETED);
}
@Test
- public void testErrorEndEventProcess() throws Exception {
- kruntime =
createKogitoProcessRuntime("org/jbpm/bpmn2/event/BPMN2-ErrorEndEvent.bpmn2");
- KogitoProcessInstance processInstance = kruntime
- .startProcess("ErrorEndEvent");
- assertProcessInstanceAborted(processInstance);
- assertThat(((org.jbpm.process.instance.ProcessInstance)
processInstance).getOutcome()).isEqualTo("error");
-
+ public void testErrorEndEventProcess() {
+ Application app = ProcessTestHelper.newApplication();
+ org.kie.kogito.process.Process<ErrorEndEventModel> process =
ErrorEndEventProcess.newProcess(app);
+ ProcessInstance<ErrorEndEventModel> processInstance =
process.createInstance(process.createModel());
+ processInstance.start();
+
assertThat(processInstance.status()).isEqualTo(org.jbpm.process.instance.ProcessInstance.STATE_ABORTED);
Review Comment:
Tried the same
public void testErrorEndEventProcess() {
Application app = ProcessTestHelper.newApplication();
org.kie.kogito.process.Process<ErrorEndEventModel> process =
ErrorEndEventProcess.newProcess(app);
ProcessInstance<ErrorEndEventModel> processInstance =
process.createInstance(process.createModel());
processInstance.start();
assertThat(processInstance.status()).isEqualTo(org.jbpm.process.instance.ProcessInstance.STATE_ABORTED);
assertThat(((org.jbpm.process.instance.ProcessInstance)
processInstance).getOutcome()).isEqualTo("error");
}
But resulting in error
[ERROR] EndEventTest.testErrorEndEventProcess:78 ClassCast class
org.jbpm.bpmn2.event.ErrorEndEventProcessInstance cannot be cast to class
org.jbpm.process.instance.ProcessInstance
(org.jbpm.bpmn2.event.ErrorEndEventProcessInstance and
org.jbpm.process.instance.ProcessInstance are in unnamed module of loader 'app')
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
