fantonangeli commented on code in PR #2595:
URL:
https://github.com/apache/incubator-kie-tools/pull/2595#discussion_r1762996672
##########
packages/runtime-tools-components/src/static/favicon.svg:
##########
Review Comment:
Please see the comment on the other image and please remove also this one if
it's not referenced.
##########
packages/runtime-tools-components/src/common/static/favicon.svg:
##########
Review Comment:
Please remove `kogito.png` from this folder if it's not referenced anymore
and rename this to `kie.svg` as we are not using it as a favicon in this
package.
##########
packages/runtime-tools-components/src/common/components/KeycloakUnavailablePage/KeycloakUnavailablePage.tsx:
##########
@@ -21,47 +21,40 @@ import { Button } from
"@patternfly/react-core/dist/js/components/Button";
import { Brand } from "@patternfly/react-core/dist/js/components/Brand";
import { Bullseye } from "@patternfly/react-core/dist/js/layouts/Bullseye";
import React from "react";
-import kogitoLogo from "../../static/kogito.png";
+import kogitoLogo from "../../static/favicon.svg";
import { OUIAProps, componentOuiaProps } from "../../ouiaTools";
+import { Text, TextContent, TextVariants } from
"@patternfly/react-core/dist/js/components/Text";
+import { Title } from "@patternfly/react-core/dist/js/components/Title";
export const KeycloakUnavailablePage: React.FC<OUIAProps> = ({ ouiaId,
ouiaSafe }) => {
return (
<div
style={{
+ background: "#d2d2d2",
+ height: "100%",
+ textAlign: "center",
display: "flex",
+ flexDirection: "column",
justifyContent: "center",
- paddingTop: "5%",
- background: "#868686",
- height: "100%",
+ color: "#6a6e73",
+ alignItems: "center",
}}
{...componentOuiaProps(ouiaId, "server-unavailable", ouiaSafe)}
>
- {" "}
- <Card
- style={{
- maxHeight: "300px",
- }}
- >
- <CardHeader>
- <CardHeaderMain>
- <Brand src={kogitoLogo} alt="Kogito keycloak" style={{ height:
"30px" }} />
- </CardHeaderMain>
- </CardHeader>
- <CardBody isFilled={false}></CardBody>
- <CardTitle>Error:503 - Server unavailable</CardTitle>
- <CardBody isFilled={false}></CardBody>
- <CardBody>Sorry.. the keycloak server seems to be down</CardBody>
- <CardBody isFilled={false}></CardBody>
- <Bullseye>
- <span>
- Please contact administrator or{" "}
- <Button variant="link" onClick={() => window.location.reload()}
isInline>
- click here to retry
- </Button>
- </span>
- </Bullseye>
- <CardBody isFilled={false}></CardBody>
- </Card>
+ <Brand src={kogitoLogo} alt="Kogito keycloak" heights={{ default:
"100px" }} />
Review Comment:
Please rename also the `kogitoLogo` import.
```suggestion
<Brand src={kieLogo} alt="KIE keycloak" heights={{ default: "100px" }}
/>
```
##########
packages/runtime-tools-components/src/common/components/KeycloakUnavailablePage/KeycloakUnavailablePage.tsx:
##########
@@ -21,47 +21,40 @@ import { Button } from
"@patternfly/react-core/dist/js/components/Button";
import { Brand } from "@patternfly/react-core/dist/js/components/Brand";
import { Bullseye } from "@patternfly/react-core/dist/js/layouts/Bullseye";
import React from "react";
-import kogitoLogo from "../../static/kogito.png";
+import kogitoLogo from "../../static/favicon.svg";
import { OUIAProps, componentOuiaProps } from "../../ouiaTools";
+import { Text, TextContent, TextVariants } from
"@patternfly/react-core/dist/js/components/Text";
+import { Title } from "@patternfly/react-core/dist/js/components/Title";
export const KeycloakUnavailablePage: React.FC<OUIAProps> = ({ ouiaId,
ouiaSafe }) => {
return (
<div
style={{
+ background: "#d2d2d2",
+ height: "100%",
+ textAlign: "center",
display: "flex",
+ flexDirection: "column",
justifyContent: "center",
- paddingTop: "5%",
- background: "#868686",
- height: "100%",
+ color: "#6a6e73",
+ alignItems: "center",
}}
{...componentOuiaProps(ouiaId, "server-unavailable", ouiaSafe)}
>
Review Comment:
Because we are refactoring this page, let's remove the old CSS and use
Patternfly's components:
```typescript
<Page>
<PageSection>
<Bullseye>
<EmptyState {...componentOuiaProps(ouiaId, "server-unavailable",
ouiaSafe)}>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
