fantonangeli commented on code in PR #2595:
URL:
https://github.com/apache/incubator-kie-tools/pull/2595#discussion_r1764767243
##########
packages/runtime-tools-components/src/common/components/KeycloakUnavailablePage/KeycloakUnavailablePage.tsx:
##########
@@ -34,19 +35,17 @@ export const KeycloakUnavailablePage: React.FC<OUIAProps> =
({ ouiaId, ouiaSafe
<Bullseye>
<EmptyState {...componentOuiaProps(ouiaId, "server-unavailable",
ouiaSafe)}>
<Brand src={kieLogo} alt="KIE keycloak" heights={{ default:
"100px" }} />
- <TextContent>
- <Text component={TextVariants.h1}>Error: 503 - Server
unavailable</Text>
- </TextContent>
- <Title headingLevel="h6" style={{ marginTop: "10px" }}>
- Sorry.. the keycloak server seems to be down.
- </Title>
- <Title headingLevel="h6">
- Please contact administrator or{" "}
- <Button variant="link" onClick={() => window.location.reload()}
isInline>
- {" "}
- click here to retry
- </Button>
+ <Title headingLevel="h1" size={TitleSizes["4xl"]}>
Review Comment:
Following the same style from http://v4-archive.patternfly.org/v4/404/
```suggestion
<Title headingLevel="h1" size={TitleSizes["2xl"]}>
```
##########
packages/runtime-tools-components/src/common/components/KeycloakUnavailablePage/KeycloakUnavailablePage.tsx:
##########
@@ -34,19 +35,17 @@ export const KeycloakUnavailablePage: React.FC<OUIAProps> =
({ ouiaId, ouiaSafe
<Bullseye>
<EmptyState {...componentOuiaProps(ouiaId, "server-unavailable",
ouiaSafe)}>
<Brand src={kieLogo} alt="KIE keycloak" heights={{ default:
"100px" }} />
- <TextContent>
- <Text component={TextVariants.h1}>Error: 503 - Server
unavailable</Text>
- </TextContent>
- <Title headingLevel="h6" style={{ marginTop: "10px" }}>
- Sorry.. the keycloak server seems to be down.
- </Title>
- <Title headingLevel="h6">
- Please contact administrator or{" "}
- <Button variant="link" onClick={() => window.location.reload()}
isInline>
- {" "}
- click here to retry
- </Button>
+ <Title headingLevel="h1" size={TitleSizes["4xl"]}>
+ 503: We couldn't contact the server
</Title>
+ <Text component={TextVariants.blockquote}>
+ We could not reach the server, you can contact the administrator
or try to reload the page by clicking on
+ the button below.
+ </Text>
+ <Button variant="primary" onClick={() => window.location.reload()}
isInline>
+ {" "}
Review Comment:
```suggestion
```
##########
packages/runtime-tools-components/src/common/components/KeycloakUnavailablePage/KeycloakUnavailablePage.tsx:
##########
@@ -34,19 +35,17 @@ export const KeycloakUnavailablePage: React.FC<OUIAProps> =
({ ouiaId, ouiaSafe
<Bullseye>
<EmptyState {...componentOuiaProps(ouiaId, "server-unavailable",
ouiaSafe)}>
<Brand src={kieLogo} alt="KIE keycloak" heights={{ default:
"100px" }} />
Review Comment:
@ricardozanini and @tiagobento
cc @domhanak
Can we use the `pf-icon-cluster` icon from Patternfly instead of the KIE
logo, to make this page more "neutral" and reusable?
http://v4-archive.patternfly.org/v4/guidelines/icons/#font-awesome-solid-fas-vs-font-awesome-regular-far
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
