gitgabrio commented on code in PR #3686:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3686#discussion_r1796633597
##########
jbpm/jbpm-flow/src/main/java/org/jbpm/process/instance/DummyKnowledgeRuntime.java:
##########
@@ -72,6 +75,10 @@ class DummyKnowledgeRuntime implements
InternalKnowledgeRuntime, KogitoProcessRu
this.processRuntime = processRuntime;
this.environment = new EnvironmentImpl();
// register codegen-based node instances factories
+ BusinessCalendar calendar =
processRuntime.getApplication().config().get(ProcessConfig.class).getBusinessCalendar();
+ if (Objects.nonNull(calendar)) {
+ environment.set("jbpm.business.calendar", calendar);
Review Comment:
Not strictly related to this PR, but strings used overall codebase as
identifiers, should be defined once as public static properties, somewhere, so
that whenever they change (as happened for
`jbpm.business.calendar.properties`-> `"calendar.properties"` ), the code keep
working.
Moreover, it is also easier to document them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
