gitgabrio commented on code in PR #3686:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3686#discussion_r1796670525
##########
jbpm/jbpm-flow/src/main/java/org/kie/kogito/process/impl/AbstractProcessConfig.java:
##########
@@ -51,6 +52,7 @@ public abstract class AbstractProcessConfig implements
ProcessConfig {
private final JobsService jobsService;
private final ProcessVersionResolver versionResolver;
private final IdentityProvider identityProvider;
+ private final BusinessCalendar businessCalendar;
protected AbstractProcessConfig(
Iterable<WorkItemHandlerConfig> workItemHandlerConfig,
Review Comment:
@pefernan @elguardian
Not related to this PR, but the parameters for this constructor are becoming
too many, and those are spreads wherever this is invoked (also in templates:
sooner or later I think it would be better to create a DTO: wdyt ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]