yesamer commented on code in PR #6127: URL: https://github.com/apache/incubator-kie-drools/pull/6127#discussion_r1804262539
########## kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/decisiontables/HitPolicy.java: ########## @@ -6,9 +6,9 @@ * to you under the Apache License, Version 2.0 (the * "License"); you may not use this file except in compliance * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> Review Comment: @gitgabrio Ooops ########## kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/functions/DecisionTableFunction.java: ########## @@ -153,7 +153,7 @@ protected List<List<UnaryTest>> objectToUnaryTestList(EvaluationContext ctx, Lis */ private static DTDecisionRule toDecisionRule(EvaluationContext mainCtx, FEEL embeddedFEEL, int index, List<?> rule, int inputSize) { // TODO should be check indeed block of inputSize n inputs, followed by block of outputs. - DTDecisionRule dr = new DTDecisionRule( index ); + DTDecisionRule dr = new DTDecisionRule( index, null ); Review Comment: @gitgabrio If is legal to have a null id, why don't have a specific constructor with the index only? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
