gitgabrio commented on code in PR #6127:
URL:
https://github.com/apache/incubator-kie-drools/pull/6127#discussion_r1804353453
##########
kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/functions/DecisionTableFunction.java:
##########
@@ -153,7 +153,7 @@ protected List<List<UnaryTest>>
objectToUnaryTestList(EvaluationContext ctx, Lis
*/
private static DTDecisionRule toDecisionRule(EvaluationContext mainCtx,
FEEL embeddedFEEL, int index, List<?> rule, int inputSize) {
// TODO should be check indeed block of inputSize n inputs, followed
by block of outputs.
- DTDecisionRule dr = new DTDecisionRule( index );
+ DTDecisionRule dr = new DTDecisionRule( index, null );
Review Comment:
good point....
Well, this specific case seems sort-of corner case, since
DecisionTableFunction has been removed (IINW) long time ago and we keep it for
compatibility.
So, adding another constructor to DTDecisionRule would make it a little bit
"ambiguous" just to cope for an exceptional case. From now on, DTDecisionRule
should always have an "id" - and if the model does not define it, the id would
be `null`- but it is slightly different then allowing instantiation completely
without it: am I clear ? Does this make sense ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
