pjfanning commented on PR #6153: URL: https://github.com/apache/incubator-kie-drools/pull/6153#issuecomment-2482874965
> > can we unzip the file and check it the underlying files? > > ``` > $ unzip ui-bundle.zip > Archive: ui-bundle.zip > creating: css/ > creating: font/ > creating: helpers/ > creating: img/ > creating: js/ > creating: layouts/ > creating: partials/ > inflating: css/site.css > inflating: font/roboto-latin-400.woff > inflating: font/roboto-latin-400.woff2 > inflating: font/roboto-latin-400italic.woff > inflating: font/roboto-latin-400italic.woff2 > inflating: font/roboto-latin-500.woff > inflating: font/roboto-latin-500.woff2 > inflating: font/roboto-latin-500italic.woff > inflating: font/roboto-latin-500italic.woff2 > inflating: font/roboto-mono-latin-400.woff > inflating: font/roboto-mono-latin-400.woff2 > inflating: font/roboto-mono-latin-500.woff > inflating: font/roboto-mono-latin-500.woff2 > inflating: helpers/and.js > inflating: helpers/detag.js > inflating: helpers/eq.js > inflating: helpers/increment.js > inflating: helpers/ne.js > inflating: helpers/not.js > inflating: helpers/or.js > inflating: helpers/relativize.js > inflating: helpers/year.js > inflating: img/back.svg > inflating: img/caret.svg > inflating: img/chevron.svg > inflating: img/home-o.svg > inflating: img/home.svg > inflating: img/menu.svg > inflating: img/octicons-16.svg > inflating: js/site.js > creating: js/vendor/ > inflating: layouts/404.hbs > inflating: layouts/default.hbs > inflating: partials/article-404.hbs > inflating: partials/article.hbs > inflating: partials/body.hbs > inflating: partials/breadcrumbs.hbs > inflating: partials/footer-content.hbs > inflating: partials/footer-scripts.hbs > inflating: partials/footer.hbs > inflating: partials/head-icons.hbs > inflating: partials/head-info.hbs > inflating: partials/head-meta.hbs > inflating: partials/head-prelude.hbs > inflating: partials/head-scripts.hbs > inflating: partials/head-styles.hbs > inflating: partials/head-title.hbs > inflating: partials/head.hbs > inflating: partials/header-content.hbs > inflating: partials/header-scripts.hbs > inflating: partials/header.hbs > inflating: partials/main.hbs > inflating: partials/nav-explore.hbs > inflating: partials/nav-menu.hbs > inflating: partials/nav-toggle.hbs > inflating: partials/nav-tree.hbs > inflating: partials/nav.hbs > inflating: partials/page-versions.hbs > inflating: partials/pagination.hbs > inflating: partials/toc.hbs > inflating: partials/toolbar.hbs > inflating: js/vendor/highlight.js > ``` > > ui-bundle.zip contains javascript, svg, font, css, hbs (html template) > > > the zip is a problem - we shouldn't have binary files in the source release > > Is this a blocker to the 10.0.0 release? @pjfanning > > If no, we would drop the `drools-docs` module from the source code distribution for the next release. If yes, still I think it's better to drop the `drools-docs` module from the source code distribution for 10.0.x... Can we exclude it from the sources zip and come back later? It could easily attract a -1 vote by including it. And in longer run, it needs to be removed and the various source files in the archive should be checked in explicitly. If you need to zip thm up when you are building from source, that's ok - that should be easy to add to your build scripting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
