tiagobento commented on PR #2726: URL: https://github.com/apache/incubator-kie-tools/pull/2726#issuecomment-2489736784
General comments: - All commands in READMEs assume you're in the example's folder. - Bootstrapping the repo with `pnpm bootstrap` is always necessary. #### @kie-tools-examples/dmn-editor-classic-on-webapp ✅ Fixed --- #### @kie-tools-examples/dmn-editor-on-webapp ✅ Fixed --- #### @kie-tools-examples/dmn-editor-on-webapp ✅ Fixed --- #### @kie-tools-examples/dmn-editor-standalone-on-webapp 🟡 Updated the port. Will investigate the failures. --- #### @kie-tools-examples/kie-sandbox-commit-message-validation-service ✅ There are no build instructions necessary here.. Simply "pnpm start" suffices. --- #### @kie-tools-examples/micro-frontends-multiplying-architecture-base64png-editor ✅ True. This is not runnable. Mentioned in the README. --- #### @kie-tools-examples/micro-frontends-multiplying-architecture-base64png-editor-chrome-extension ✅ There are some in this repo! :) Or you can use the Base64 Editor VS Code Extension to create some based on PNG files. --- #### @kie-tools-examples/micro-frontends-multiplying-architecture-base64png-editor-on-webapp ✅ Nothing done. --- #### kie-tools-examples-micro-frontends-multiplying-architecture-base64png-editor-vscode-extension ✅ Not having the scope (`@kie-tools`) part in the name of the package is a requirement from the VS Code Marketplace. Fixed the build command. Build failed for you because you didn't bootstrap first, I guess? --- #### @kie-tools-examples/micro-frontends-multiplying-architecture-ping-pong-view ✅ OK --- #### @kie-tools-examples/micro-frontends-multiplying-architecture-ping-pong-view-in-angular ✅ This is not runnable. I made it clear on the README now. --- #### @kie-tools-examples/micro-frontends-multiplying-architecture-ping-pong-view-in-react ✅ Same as above. --- #### @kie-tools-examples/micro-frontends-multiplying-architecture-ping-pong-views-on-webapp ✅ OK --- #### @kie-tools-examples/micro-frontends-multiplying-architecture-todo-list-view 🟡 Not sure I understand your feedback here... --- #### @kie-tools-examples/micro-frontends-multiplying-architecture-todo-list-view-on-webapp ✅ OK ---- #### kie-tools-examples-micro-frontends-multuplying-architecture-todo-list-view-vscode-extension ✅ Please see the other VS Code extension example's comment from my end as they apply here too. --- #### @kie-tools-examples/process-compact-architecture ✅ True... this is expected, and we need to upgrade the Kogito version of the repo. I'll do it soon in a separate PR. --- #### @kie-tools-examples/process-user-tasks-subsystem 🟡 Weird... Will investigate. Thanks! --- #### @kie-tools-examples/serverless-workflow-editor-standalone-on-webapp ✅ OK --- #### @kie-tools-examples/sonataflow-greeting ✅ Out of scope of this PR. ---- ### @kie-tools-examples/uniforms-patternfly ✅ Out of scope of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
