tiagobento commented on PR #2726:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2726#issuecomment-2524710811

   ### @kie-tools-examples/process-user-tasks-subsystem
   ✅ Removed the test... The example compiles normally now. We currently don't 
have tests for our examples, but I guess if we want that, we need a new 
"examples-tests" top-level directory to host them.
   
   ---
   
   ### 
@kie-tools-examples/micro-frontends-multiplying-architecture-todo-list-view
   ✅ As we discussed, this is ok.
   
   ---
   
   ### @kie-tools-examples/dmn-editor-standalone-on-webapp
   ✅ Took me a while to read the comment, but I finally did:
   
   >  // The paths are important here! Since path2/loan-pre-qualification.dmn 
is in a
     // different parent path than the main content (path1/can-drive.dmn), it 
won't be availabe
     // to be used as an included model.
   
   I added a comment to the specific line pointing to the main comment:
    
   `["path2/loan-pre-qualification.dmn", { contentType: "text", content: 
loadFile("loan-pre-qualification.dmn") }], // Won't be available! Read comment 
above.`
   
   
   ---
   
   
   Hope it's in good shape now @jomarko. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to