chrisdutz commented on code in PR #2111:
URL: 
https://github.com/apache/incubator-kie-kogito-apps/pull/2111#discussion_r1858112629


##########
LICENSE:
##########
@@ -199,3 +199,8 @@
    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    See the License for the specific language governing permissions and
    limitations under the License.
+
+---------------------------------------------------------------------------------
+for 
./jitexecutor/jitexecutor-dmn/src/main/resources/META-INF/resources/bundle.js
+
+TODO check facebook thing

Review Comment:
   Unfortunately I'm not too deep into this project ... generally the "Licensed 
to the Apache Software" foundation header should only be used if it contains a 
significant amount of content from an Apache project and not simply stuff 
that's licensed under the Apache 2.0 license. 
   
   Do I understand it correctly, that 
./jitexecutor/jitexecutor-dmn/src/main/resources/META-INF/resources/bundle.js 
contains resources from various sources? Usually in such a case it would be 
good to mention which parts are taken from which project and which license they 
are under. Would that be possible? Because otherwise it's not really possible 
to correctly find out which code is licensed under which license.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to