fantonangeli commented on code in PR #2750:
URL:
https://github.com/apache/incubator-kie-tools/pull/2750#discussion_r1871901878
##########
packages/sonataflow-management-console-image/package.json:
##########
@@ -28,7 +30,10 @@
"image:cekit:build:linux": "pnpm image:cekit:copy && pnpm
image:cekit:setup:env make -C ./dist-dev build",
"image:cekit:build:win32:darwin": "echo \"Build skipped on macOS and
Windows\"",
"image:cekit:copy": "cp -R
./node_modules/@kie-tools/sonataflow-image-common/resources/* ./dist-dev/ && cp
-R resources/* ./dist-dev/",
- "image:cekit:setup:env": ".
./node_modules/@kie-tools/python-venv/venv/bin/activate && cross-env
KOGITO_IMAGE_REGISTRY=$(build-env sonataflowManagementConsoleImageEnv.registry)
KOGITO_IMAGE_REGISTRY_ACCOUNT=$(build-env
sonataflowManagementConsoleImageEnv.account) KOGITO_IMAGE_NAME=$(build-env
sonataflowManagementConsoleImageEnv.name) KOGITO_IMAGE_TAG=$(build-env
sonataflowManagementConsoleImageEnv.buildTag)
QUARKUS_PLATFORM_VERSION=$(build-env versions.quarkus)
KOGITO_VERSION=$(build-env versions.kogito)
SONATAFLOW_MANAGEMENT_CONSOLE_PORT=$(build-env
sonataflowManagementConsoleImageEnv.port)"
+ "image:cekit:setup:env": ".
./node_modules/@kie-tools/python-venv/venv/bin/activate && cross-env
KOGITO_IMAGE_REGISTRY=$(build-env sonataflowManagementConsoleImageEnv.registry)
KOGITO_IMAGE_REGISTRY_ACCOUNT=$(build-env
sonataflowManagementConsoleImageEnv.account) KOGITO_IMAGE_NAME=$(build-env
sonataflowManagementConsoleImageEnv.name) KOGITO_IMAGE_TAG=$(build-env
sonataflowManagementConsoleImageEnv.buildTag)
QUARKUS_PLATFORM_VERSION=$(build-env versions.quarkus)
KOGITO_VERSION=$(build-env versions.kogito)
SONATAFLOW_MANAGEMENT_CONSOLE_PORT=$(build-env
sonataflowManagementConsoleImageEnv.port)",
+ "image:test": "run-script-if --ignore-errors \"$(build-env
tests.ignoreFailures)\" --bool \"$(build-env endToEndTests.run)\" --then
\"mkdir -p dist-dev/target/test/results\" \"run-script-os\" --finally \"cp -R
dist-dev/target/test/results dist-tests-e2e/\"",
+ "image:test:darwin:win32": "echo \"Tests skipped on macOS and Windows\"",
+ "image:test:linux": "pnpm copy:test-assets && pnpm image:cekit:setup:env
SONATAFLOW_MANAGEMENT_CONSOLE_DATA_INDEX_ENDPOINT='http://$(hostname -I | awk
'{print $1}'):4000/graphql' make -C ./dist-dev test-image"
Review Comment:
Maybe there is a better approach to communicating with the host machine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
