ricardozanini commented on code in PR #2750: URL: https://github.com/apache/incubator-kie-tools/pull/2750#discussion_r1871906338
########## .gitignore: ########## @@ -324,6 +324,7 @@ packages/scesim-marshaller/**/ts-gen !packages/sonataflow-image-common/test-resources/ !packages/sonataflow-builder-image/test-resources/ !packages/sonataflow-devmode-image/test-resources/ +!packages/sonataflow-management-console-image/test-resources/ Review Comment: Can't we use the gitignore files within the package instead? ########## packages/sonataflow-management-console-image/test-resources/tests/features/sonataflow-management-console.feature: ########## @@ -0,0 +1,37 @@ [email protected]/apache/incubator-kie-sonataflow-management-console +Feature: Serverless Workflow Management Console images + + Scenario: verify that the home page is served + When container is started with env + | variable | value | + Then container log should contain httpd -D FOREGROUND + Then check that page is served + | property | value | + | port | 8080 | + | path | / | + | request_method | GET | + | wait | 480 | + | expected_status_code | 200 | + + Scenario: Verify that the rewrite rule for /graphql is in httpd.conf + When container is started with env + | variable | value | + Then container log should contain httpd -D FOREGROUND + Then file /etc/httpd/conf/httpd.conf should contain /graphql + + + Scenario: verify that the data-index is available from the container + When container is started with env + | variable | value | + | SONATAFLOW_MANAGEMENT_CONSOLE_DATA_INDEX_ENDPOINT | http://192.168.138.171:4000/graphql | Review Comment: The IP is required because you are using the internal Docker network to expose the service and have Cekit behave to query it. We could set up a virtual DNS, but it would take too much effort; I don't think it's worth it. Can we predict the IP and hardcode it in this test? Or you could fetch for the IP and pass this variable during the test command line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
