gitgabrio commented on code in PR #6213:
URL:
https://github.com/apache/incubator-kie-drools/pull/6213#discussion_r1916933871
##########
kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/functions/IsFunction.java:
##########
@@ -45,7 +46,7 @@ public FEELFnResult<Boolean> invoke(@ParameterName("value1")
Object value1, @Par
return
FEELFnResult.ofResult(BooleanEvalHelper.isEqualDateTimeInSemanticD(left,
right));
} // fallback; continue:
}
- Boolean fallback = BooleanEvalHelper.isEqual(value1, value2); // if
null implying they are not the same semantic domain value.
+ Boolean fallback = BooleanEvalHelper.isEqual(value1, value2,
FEELDialect.FEEL); // if null implying they are not the same semantic domain
value.
Review Comment:
I've addressed it. Anyway, I also kept the old "workaround" (the invocation
with the FEEL dialect) to avoid potentially breaking changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
