gitgabrio commented on code in PR #6213:
URL:
https://github.com/apache/incubator-kie-drools/pull/6213#discussion_r1919957490
##########
kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/util/BooleanEvalHelper.java:
##########
@@ -179,6 +180,70 @@ public static Boolean
isEqualTimeInSemanticD(TemporalAccessor left, TemporalAcce
return result;
}
+ /**
+ * This method consider if the <code>value</code> object is a
<code>String</code>
+ * In that case, return the <code>String.equal</code> result
+ * Otherwise, default to the <code>isEqual</code>
+ * @param value
+ * @param itemFromList
+ * @return
+ */
+ public static boolean isEqualsStringCompare(Object value, Object
itemFromList) {
Review Comment:
HI @jomarko
I see your point and in general I agree.
Alas, in this very case, the method does both you mention, depending on the
parameters.
I could not find a better way to describe
(`isEqualWtihStringCompareOrByDefaultIsEqual` ? )
and that's why I also add javadoc.
Moreover, I'm not even 100% sure why this method is needed (from functional
POV), even if I see it is used in two places.
Anyway, as small "plus", keep in mind that this method previously was named
`isEqualSC` and it was in a completely unrelated class, so, even if not
"perfect", it seems a small improvement 😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
