tiagobento commented on code in PR #2866:
URL:
https://github.com/apache/incubator-kie-tools/pull/2866#discussion_r1930717117
##########
packages/root-env/env/index.js:
##########
@@ -93,6 +97,9 @@ module.exports = composeEnv([], {
run:
str2bool(getOrDefault(this.vars.KIE_TOOLS_BUILD__runEndToEndTests)),
ignoreFailures:
str2bool(getOrDefault(this.vars.KIE_TOOLS_BUILD__ignoreEndToEndTestFailures)),
},
+ containerizedEndToEndTests: {
+ run:
str2bool(getOrDefault(this.vars.KIE_TOOLS_BUILD__runContainerizedEndToEndTests)),
+ },
Review Comment:
So I think the `KIE_TOOLS_BUILD__runEndToEndTests` env var should still be
the one use to toggle the execution of the E2E tests, and this new flag should
only toggle the MODE with which the tests run.
```bash
KIE_TOOLS_BUILD__runEndToEndTests=false
# E2E tests don't run and `KIE_TOOLS_BUILD__runContainerizedEndToEndTests`
is ignored.
```
```bash
KIE_TOOLS_BUILD__runEndToEndTests=true
KIE_TOOLS_BUILD__runContainerizedEndToEndTests=true
# E2E tests run inside containers
```
```bash
KIE_TOOLS_BUILD__runEndToEndTests=true
KIE_TOOLS_BUILD__runContainerizedEndToEndTests=false (default)
# E2E tests run on host machine (without containers involved)
```
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
