tiagobento commented on code in PR #2866:
URL:
https://github.com/apache/incubator-kie-tools/pull/2866#discussion_r1951534988
##########
packages/online-editor/playwright.config.ts:
##########
@@ -61,6 +62,35 @@ const customConfig = defineConfig({
timeout: 240000,
},
],
+ // Override
+ projects: process.env.KIE_TOOLS_ONLINE_EDITOR__SKIP_PLAYWRIGHT_FOR_ARM64
Review Comment:
Not using `build-env` here and directly accessing an env var. This is not
aligned with the repository's convention...
##########
packages/online-editor/playwright.config.ts:
##########
@@ -61,6 +62,35 @@ const customConfig = defineConfig({
timeout: 240000,
},
],
+ // Override
+ projects: process.env.KIE_TOOLS_ONLINE_EDITOR__SKIP_PLAYWRIGHT_FOR_ARM64
Review Comment:
Not using build-env to access an environment variable...
##########
packages/scesim-editor/tests-e2e/__containerization__/playwright-docker-compose.yml:
##########
@@ -0,0 +1,64 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+services:
+ playwright:
+ platform: linux/amd64
+ container_name: kie-tools-playwright-containerization-scesim-editor
+ image:
dev.local/${USER}/kie-tools-playwright-container-image:${PROJECT_VERSION}
Review Comment:
This name is not parameterized, and the ${USER} component there seems
unnecessary. WDYT about
`dev.local/apache-kie-tools/playwright-e2e-tests-image`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
